From 0a0f667bbd849479e852901a22de366d41d87fcb Mon Sep 17 00:00:00 2001
From: Will Jones <willjones127@gmail.com>
Date: Tue, 24 Dec 2024 12:50:54 -0800
Subject: [PATCH] chore: fix typos (#1976)

---
 .github/workflows/npm-publish.yml | 142 +++++++++++++++---------------
 1 file changed, 71 insertions(+), 71 deletions(-)

diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml
index efce7d1a..07fe8645 100644
--- a/.github/workflows/npm-publish.yml
+++ b/.github/workflows/npm-publish.yml
@@ -380,39 +380,39 @@ jobs:
   #         path: |
   #           node/dist/lancedb-vectordb-win32*.tgz
 
-  # nodejs-windows:
-  #   name: lancedb ${{ matrix.target }}
-  #   runs-on: windows-2022
-  #   # Only runs on tags that matches the make-release action
-  #   if: startsWith(github.ref, 'refs/tags/v')
-  #   strategy:
-  #     fail-fast: false
-  #     matrix:
-  #       target: [x86_64-pc-windows-msvc]
-  #   steps:
-  #     - name: Checkout
-  #       uses: actions/checkout@v4
-  #     - name: Install Protoc v21.12
-  #       working-directory: C:\
-  #       run: |
-  #         New-Item -Path 'C:\protoc' -ItemType Directory
-  #         Set-Location C:\protoc
-  #         Invoke-WebRequest https://github.com/protocolbuffers/protobuf/releases/download/v21.12/protoc-21.12-win64.zip -OutFile C:\protoc\protoc.zip
-  #         7z x protoc.zip
-  #         Add-Content $env:GITHUB_PATH "C:\protoc\bin"
-  #       shell: powershell
-  #     - name: Install npm dependencies
-  #       run: |
-  #         cd nodejs
-  #         npm ci
-  #     - name: Build Windows native node modules
-  #       run: .\ci\build_windows_artifacts_nodejs.ps1 ${{ matrix.target }}
-  #     - name: Upload Windows Artifacts
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: nodejs-native-windows
-  #         path: |
-  #           nodejs/dist/*.node
+  nodejs-windows:
+    name: lancedb ${{ matrix.target }}
+    runs-on: windows-2022
+    # Only runs on tags that matches the make-release action
+    if: startsWith(github.ref, 'refs/tags/v')
+    strategy:
+      fail-fast: false
+      matrix:
+        target: [x86_64-pc-windows-msvc]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Install Protoc v21.12
+        working-directory: C:\
+        run: |
+          New-Item -Path 'C:\protoc' -ItemType Directory
+          Set-Location C:\protoc
+          Invoke-WebRequest https://github.com/protocolbuffers/protobuf/releases/download/v21.12/protoc-21.12-win64.zip -OutFile C:\protoc\protoc.zip
+          7z x protoc.zip
+          Add-Content $env:GITHUB_PATH "C:\protoc\bin"
+        shell: powershell
+      - name: Install npm dependencies
+        run: |
+          cd nodejs
+          npm ci
+      - name: Build Windows native node modules
+        run: .\ci\build_windows_artifacts_nodejs.ps1 ${{ matrix.target }}
+      - name: Upload Windows Artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: nodejs-native-windows
+          path: |
+            nodejs/dist/*.node
 
   # TODO: https://github.com/lancedb/lancedb/issues/1975
   # nodejs-windows-arm64:
@@ -463,45 +463,45 @@ jobs:
   #         path: |
   #           nodejs/dist/*.node
 
-  # release:
-  #   name: vectordb NPM Publish
-  #   needs: [node, node-macos, node-linux-gnu, node-linux-musl, node-windows]
-  #   runs-on: ubuntu-latest
-  #   # Only runs on tags that matches the make-release action
-  #   if: startsWith(github.ref, 'refs/tags/v')
-  #   steps:
-  #     - uses: actions/download-artifact@v4
-  #       with:
-  #         pattern: node-*
-  #     - name: Display structure of downloaded files
-  #       run: ls -R
-  #     - uses: actions/setup-node@v3
-  #       with:
-  #         node-version: 20
-  #         registry-url: "https://registry.npmjs.org"
-  #     - name: Publish to NPM
-  #       env:
-  #         NODE_AUTH_TOKEN: ${{ secrets.LANCEDB_NPM_REGISTRY_TOKEN }}
-  #       run: |
-  #         # Tag beta as "preview" instead of default "latest". See lancedb
-  #         # npm publish step for more info.
-  #         if [[ $GITHUB_REF =~ refs/tags/v(.*)-beta.* ]]; then
-  #           PUBLISH_ARGS="--tag preview"
-  #         fi
+  release:
+    name: vectordb NPM Publish
+    needs: [node, node-macos, node-linux-gnu, node-linux-musl, node-windows]
+    runs-on: ubuntu-latest
+    # Only runs on tags that matches the make-release action
+    if: startsWith(github.ref, 'refs/tags/v')
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          pattern: node-*
+      - name: Display structure of downloaded files
+        run: ls -R
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 20
+          registry-url: "https://registry.npmjs.org"
+      - name: Publish to NPM
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.LANCEDB_NPM_REGISTRY_TOKEN }}
+        run: |
+          # Tag beta as "preview" instead of default "latest". See lancedb
+          # npm publish step for more info.
+          if [[ $GITHUB_REF =~ refs/tags/v(.*)-beta.* ]]; then
+            PUBLISH_ARGS="--tag preview"
+          fi
 
-  #         mv */*.tgz .
-  #         for filename in *.tgz; do
-  #           npm publish $PUBLISH_ARGS $filename
-  #         done
-  #     - name: Notify Slack Action
-  #       uses: ravsamhq/notify-slack-action@2.3.0
-  #       if: ${{ always() }}
-  #       with:
-  #         status: ${{ job.status }}
-  #         notify_when: "failure"
-  #         notification_title: "{workflow} is failing"
-  #       env:
-  #         SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
+          mv */*.tgz .
+          for filename in *.tgz; do
+            npm publish $PUBLISH_ARGS $filename
+          done
+      - name: Notify Slack Action
+        uses: ravsamhq/notify-slack-action@2.3.0
+        if: ${{ always() }}
+        with:
+          status: ${{ job.status }}
+          notify_when: "failure"
+          notification_title: "{workflow} is failing"
+        env:
+          SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }}
 
   release-nodejs:
     name: lancedb NPM Publish