From 140a4e2f530bdb5d88ebe80f5d43cf8eeba26453 Mon Sep 17 00:00:00 2001 From: Wyatt Alt Date: Mon, 18 Aug 2025 05:49:06 -0700 Subject: [PATCH] chore: add storage_options to object_store wrap() Adds storage_options to object_store wrap() to adhere to upstream lance change. --- rust/lancedb/src/io/object_store.rs | 6 +++++- rust/lancedb/src/io/object_store/io_tracking.rs | 6 +++++- rust/lancedb/src/table.rs | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/rust/lancedb/src/io/object_store.rs b/rust/lancedb/src/io/object_store.rs index cb76a1e02..f35e2ec6f 100644 --- a/rust/lancedb/src/io/object_store.rs +++ b/rust/lancedb/src/io/object_store.rs @@ -170,7 +170,11 @@ impl MirroringObjectStoreWrapper { } impl WrappingObjectStore for MirroringObjectStoreWrapper { - fn wrap(&self, primary: Arc) -> Arc { + fn wrap( + &self, + primary: Arc, + _storage_options: Option<&std::collections::HashMap>, + ) -> Arc { Arc::new(MirroringObjectStore { primary, secondary: self.secondary.clone(), diff --git a/rust/lancedb/src/io/object_store/io_tracking.rs b/rust/lancedb/src/io/object_store/io_tracking.rs index 7d580e6fe..6bfdaebcc 100644 --- a/rust/lancedb/src/io/object_store/io_tracking.rs +++ b/rust/lancedb/src/io/object_store/io_tracking.rs @@ -50,7 +50,11 @@ impl IoStatsHolder { } impl WrappingObjectStore for IoStatsHolder { - fn wrap(&self, target: Arc) -> Arc { + fn wrap( + &self, + target: Arc, + _storage_options: Option<&std::collections::HashMap>, + ) -> Arc { Arc::new(IoTrackingStore { target, stats: self.0.clone(), diff --git a/rust/lancedb/src/table.rs b/rust/lancedb/src/table.rs index 1bbeed527..930f763a0 100644 --- a/rust/lancedb/src/table.rs +++ b/rust/lancedb/src/table.rs @@ -3264,6 +3264,7 @@ mod tests { fn wrap( &self, original: Arc, + _storage_options: Option<&std::collections::HashMap>, ) -> Arc { self.called.store(true, Ordering::Relaxed); original