fix: honor downstream Lance dependency overrides (#4671)

mirror of https://github.com/lancedb/lancedb.git synced 2026-10-27 22:16:14 +00:00

Consumers that provide a local Lance checkout cannot resolve the
dependency graph because the SDK directly selects a vendored
`lance-arrow`, producing two path packages with the same name and
version. The Rust core now declares its upstream Git dependency
separately so the consuming workspace can override that source
consistently. Python continues inheriting the vendored workspace
dependency, keeping the sliced-struct validity fix in Maturin source
distributions. Standalone SDK builds still select that same fix through
the existing root patch.

Adds a downstream consumer CI regression that resolves a local Lance
override and checks that exactly one canonical `lance-arrow` package is
selected. The Lance version updater also updates the core declaration in
stable, preview and local modes. Public APIs and query behavior are
unchanged.

The workspace declaration lint excludes path dependencies because the
Python binding intentionally uses the bundled source. Duplicate and
unused external declarations remain errors; advisory, license,
banned-package and source checks continue covering the full dependency
graph.

---------

Co-authored-by: Lance Release <lance-dev@lancedb.com>

This commit is contained in:

Jack Ye

2026-10-25 07:19:55 -07:00

committed by

GitHub

co-authored by

Lance Release

parent de0c5edc7d

commit 197403e891

7 changed files with 106 additions and 3 deletions

									
										python/Cargo.toml
									
		-1
	
												View File
												
				@@ -22,7 +22,6 @@ bytes.workspace = true

				lancedb.workspace = true

				datafusion-common.workspace = true

				lance-core.workspace = true

				# The workspace path dependency includes the patched crate in Maturin sources.

				lance-arrow.workspace = true

				lance-namespace.workspace = true

				lance-namespace-impls.workspace = true