From 1ac745eb18b9fd27ef1642674128b604d0df3f10 Mon Sep 17 00:00:00 2001 From: Will Jones Date: Mon, 6 Oct 2025 09:40:08 -0700 Subject: [PATCH] ci: fix Python and Node CI on main (#2700) Example failure: https://github.com/lancedb/lancedb/actions/runs/18237024283/job/51932651993 --- .github/workflows/nodejs.yml | 1 + .github/workflows/python.yml | 1 + docs/src/js/classes/MergeInsertBuilder.md | 24 +++++++++++++++++++++++ rust/lancedb/src/table.rs | 6 +++--- 4 files changed, 29 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index a0d5af2c..44edfee2 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -6,6 +6,7 @@ on: - main pull_request: paths: + - Cargo.toml - nodejs/** - .github/workflows/nodejs.yml - docker-compose.yml diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml index 30377f3d..a55cb070 100644 --- a/.github/workflows/python.yml +++ b/.github/workflows/python.yml @@ -6,6 +6,7 @@ on: - main pull_request: paths: + - Cargo.toml - python/** - .github/workflows/python.yml diff --git a/docs/src/js/classes/MergeInsertBuilder.md b/docs/src/js/classes/MergeInsertBuilder.md index 09664e62..ae601c9e 100644 --- a/docs/src/js/classes/MergeInsertBuilder.md +++ b/docs/src/js/classes/MergeInsertBuilder.md @@ -52,6 +52,30 @@ the merge result *** +### useIndex() + +```ts +useIndex(useIndex): MergeInsertBuilder +``` + +Controls whether to use indexes for the merge operation. + +When set to `true` (the default), the operation will use an index if available +on the join key for improved performance. When set to `false`, it forces a full +table scan even if an index exists. This can be useful for benchmarking or when +the query optimizer chooses a suboptimal path. + +#### Parameters + +* **useIndex**: `boolean` + Whether to use indices for the merge operation. Defaults to `true`. + +#### Returns + +[`MergeInsertBuilder`](MergeInsertBuilder.md) + +*** + ### whenMatchedUpdateAll() ```ts diff --git a/rust/lancedb/src/table.rs b/rust/lancedb/src/table.rs index eda1344c..fa2d5108 100644 --- a/rust/lancedb/src/table.rs +++ b/rust/lancedb/src/table.rs @@ -1398,19 +1398,19 @@ impl Tags for NativeTags { } async fn create(&mut self, tag: &str, version: u64) -> Result<()> { - let dataset = self.dataset.get_mut().await?; + let dataset = self.dataset.get().await?; dataset.tags().create(tag, version).await?; Ok(()) } async fn delete(&mut self, tag: &str) -> Result<()> { - let dataset = self.dataset.get_mut().await?; + let dataset = self.dataset.get().await?; dataset.tags().delete(tag).await?; Ok(()) } async fn update(&mut self, tag: &str, version: u64) -> Result<()> { - let dataset = self.dataset.get_mut().await?; + let dataset = self.dataset.get().await?; dataset.tags().update(tag, version).await?; Ok(()) }