From 2d899675e8dc37c27a827ba4d2263b4ac7fb91af Mon Sep 17 00:00:00 2001 From: gsilvestrin Date: Thu, 20 Jul 2023 13:15:29 -0700 Subject: [PATCH] bugfix(node): Make release task can't push to repo (#344) --- .github/workflows/make-release-commit.yml | 11 ++++++++++- .github/workflows/npm-publish.yml | 2 ++ .github/workflows/update_package_lock/action.yml | 13 ++++++++++++- .github/workflows/update_package_lock_run.yml | 2 ++ 4 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/workflows/make-release-commit.yml b/.github/workflows/make-release-commit.yml index 9fe2f59c..e4202a49 100644 --- a/.github/workflows/make-release-commit.yml +++ b/.github/workflows/make-release-commit.yml @@ -44,6 +44,15 @@ jobs: run: | pip install bump2version bumpversion --verbose ${{ inputs.part }} - git push + - name: Push new version and tag + if: ${{ inputs.dry_run }} == "false" + uses: ad-m/github-push-action@master + with: + github_token: ${{ secrets.LANCEDB_RELEASE_TOKEN }} + branch: main + tags: true - uses: ./.github/workflows/update_package_lock + if: ${{ inputs.dry_run }} == "false" + with: + github_token: ${{ secrets.LANCEDB_RELEASE_TOKEN }} diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index b9977629..77c2f360 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -178,3 +178,5 @@ jobs: - name: Checkout uses: actions/checkout@v3 - uses: ./.github/workflows/update_package_lock + with: + github_token: ${{ secrets.LANCEDB_RELEASE_TOKEN }} diff --git a/.github/workflows/update_package_lock/action.yml b/.github/workflows/update_package_lock/action.yml index b931d99a..132eaddf 100644 --- a/.github/workflows/update_package_lock/action.yml +++ b/.github/workflows/update_package_lock/action.yml @@ -1,6 +1,11 @@ name: update_package_lock description: "Update node's package.lock" +inputs: + github_token: + required: true + description: "github token for the repo" + runs: using: "composite" steps: @@ -18,5 +23,11 @@ runs: npm install git add package-lock.json git commit -m "Updating package-lock.json" - git push shell: bash + - name: Push changes + if: ${{ inputs.dry_run }} == "false" + uses: ad-m/github-push-action@master + with: + github_token: ${{ inputs.github_token }} + branch: main + tags: true diff --git a/.github/workflows/update_package_lock_run.yml b/.github/workflows/update_package_lock_run.yml index 04bce285..ff8fdce2 100644 --- a/.github/workflows/update_package_lock_run.yml +++ b/.github/workflows/update_package_lock_run.yml @@ -10,3 +10,5 @@ jobs: - name: Checkout uses: actions/checkout@v3 - uses: ./.github/workflows/update_package_lock + with: + github_token: ${{ secrets.LANCEDB_RELEASE_TOKEN }}