rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-05-26 00:10:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: bump lance to 8.10 (#622)

Browse Source
This commit is contained in:
Lei Xu
2023-11-01 14:14:38 -07:00
committed by GitHub
parent 2cb91e818d
commit 2e0f251bfd
5 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
rust/ffi/node/src/index/vector.rs
View File

@@ -70,7 +70,6 @@ fn get_index_params_builder(
.map(|mt| {
let metric_type = mt.unwrap();
index_builder.metric_type(metric_type);
pq_params.metric_type = metric_type;
});
let num_partitions = obj.get_opt_usize(cx, "num_partitions")?;

8
rust/vectordb/src/index/vector.rs
View File

@@ -99,7 +99,11 @@ impl VectorIndexBuilder for IvfPQIndexBuilder {
let ivf_params = self.ivf_params.clone().unwrap_or_default();
let pq_params = self.pq_params.clone().unwrap_or_default();
VectorIndexParams::with_ivf_pq_params(pq_params.metric_type, ivf_params, pq_params)
VectorIndexParams::with_ivf_pq_params(
self.metric_type.unwrap_or(MetricType::L2),
ivf_params,
pq_params,
)
}
fn get_replace(&self) -> bool {
@@ -180,7 +184,6 @@ mod tests {
pq_params.max_iters = 1;
pq_params.num_bits = 8;
pq_params.num_sub_vectors = 50;
pq_params.metric_type = MetricType::Cosine;
pq_params.max_opq_iters = 2;
index_builder.ivf_params(ivf_params);
index_builder.pq_params(pq_params);
@@ -198,7 +201,6 @@ mod tests {
assert_eq!(pq_params.max_iters, 1);
assert_eq!(pq_params.num_bits, 8);
assert_eq!(pq_params.num_sub_vectors, 50);
assert_eq!(pq_params.metric_type, MetricType::Cosine);
assert_eq!(pq_params.max_opq_iters, 2);
} else {
assert!(false, "Expected second stage to be pq")

13
rust/vectordb/src/table.rs
View File

@@ -27,7 +27,7 @@ use lance::io::object_store::WrappingObjectStore;
use std::path::Path;
use crate::error::{Error, Result};
use crate::index::vector::{VectorIndexBuilder, VectorIndex};
use crate::index::vector::{VectorIndex, VectorIndexBuilder};
use crate::query::Query;
use crate::utils::{PatchReadParam, PatchWriteParam};
use crate::WriteMode;
@@ -393,11 +393,12 @@ impl Table {
}
pub async fn load_indices(&self) -> Result<Vec<VectorIndex>> {
let (indices, mf) = futures::try_join!(
self.dataset.load_indices(),
self.dataset.latest_manifest()
)?;
Ok(indices.iter().map(|i| VectorIndex::new_from_format(&mf, i)).collect())
let (indices, mf) =
futures::try_join!(self.dataset.load_indices(), self.dataset.latest_manifest())?;
Ok(indices
.iter()
.map(|i| VectorIndex::new_from_format(&mf, i))
.collect())
}
}