rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-01-06 11:52:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: support azure account name storage options in sync db.connect (#1926)

Browse Source 
db.connect with azure storage account name is supported in async connect
but not sync connect.
Add this functionality

---------

Co-authored-by: Will Jones <willjones127@gmail.com>
This commit is contained in:
LuQQiu
2024-12-08 20:00:23 -08:00
committed by GitHub
parent a5ebe5a6c4
commit 35bacdd57e
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
python/python/lancedb/__init__.py
View File

@@ -110,6 +110,7 @@ def connect(
# TODO: remove this (deprecation warning downstream) # TODO: remove this (deprecation warning downstream)
request_thread_pool=request_thread_pool, request_thread_pool=request_thread_pool,
client_config=client_config, client_config=client_config,
storage_options=storage_options,
**kwargs, **kwargs,
) )

3
python/python/lancedb/remote/db.py
View File

@@ -44,9 +44,9 @@ class RemoteDBConnection(DBConnection):
client_config: Union[ClientConfig, Dict[str, Any], None] = None, client_config: Union[ClientConfig, Dict[str, Any], None] = None,
connection_timeout: Optional[float] = None, connection_timeout: Optional[float] = None,
read_timeout: Optional[float] = None, read_timeout: Optional[float] = None,
storage_options: Optional[Dict[str, str]] = None,
): ):
"""Connect to a remote LanceDB database.""" """Connect to a remote LanceDB database."""
if isinstance(client_config, dict): if isinstance(client_config, dict):
client_config = ClientConfig(**client_config) client_config = ClientConfig(**client_config)
elif client_config is None: elif client_config is None:
@@ -94,6 +94,7 @@ class RemoteDBConnection(DBConnection):
region=region, region=region,
host_override=host_override, host_override=host_override,
client_config=client_config, client_config=client_config,
storage_options=storage_options,
) )
) )