From 381e7cb9a64d4d16b91ca5ed8f9ef5a06766c4d0 Mon Sep 17 00:00:00 2001 From: Jack Ye Date: Fri, 30 Jan 2026 17:28:15 -0800 Subject: [PATCH] Revert "fix: pass storage_options in LanceNamespaceDatabase::create_table" This reverts commit 1078983993adfd59b1b765e0a30e727b5e3a9fc6. --- rust/lancedb/src/database/namespace.rs | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/rust/lancedb/src/database/namespace.rs b/rust/lancedb/src/database/namespace.rs index b9b0f9a5a..b8ad19cd0 100644 --- a/rust/lancedb/src/database/namespace.rs +++ b/rust/lancedb/src/database/namespace.rs @@ -7,8 +7,6 @@ use std::collections::HashMap; use std::sync::Arc; use async_trait::async_trait; -use lance::io::ObjectStoreParams; -use lance_io::object_store::StorageOptionsAccessor; use lance_namespace::{ models::{ CreateEmptyTableRequest, CreateNamespaceRequest, CreateNamespaceResponse, @@ -255,21 +253,6 @@ impl Database for LanceNamespaceDatabase { } }; - // Inject storage_options into write params if we have them - let mut params = request.write_options.lance_write_params; - if !self.storage_options.is_empty() { - let params_ref = params.get_or_insert_with(Default::default); - let store_params = params_ref - .store_params - .get_or_insert_with(ObjectStoreParams::default); - // Only set if not already set by user - if store_params.storage_options_accessor.is_none() { - store_params.storage_options_accessor = Some(Arc::new( - StorageOptionsAccessor::with_static_options(self.storage_options.clone()), - )); - } - } - let native_table = NativeTable::create_from_namespace( self.namespace.clone(), &location, @@ -277,7 +260,7 @@ impl Database for LanceNamespaceDatabase { request.namespace.clone(), request.data, None, // write_store_wrapper not used for namespace connections - params, + request.write_options.lance_write_params, self.read_consistency_interval, self.server_side_query_enabled, self.session.clone(),