From 3b173e7cb96426278e4854a6563d25a75c11f33d Mon Sep 17 00:00:00 2001
From: QianZhu <qian@lancedb.com>
Date: Tue, 26 Nov 2024 11:01:25 -0800
Subject: [PATCH] fix: default limit for remote nodejs client (#1886)

https://github.com/lancedb/lancedb/issues/1804
---
 rust/lancedb/src/connection.rs   | 2 ++
 rust/lancedb/src/query.rs        | 2 +-
 rust/lancedb/src/remote/table.rs | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/rust/lancedb/src/connection.rs b/rust/lancedb/src/connection.rs
index 8946beee6..83c850652 100644
--- a/rust/lancedb/src/connection.rs
+++ b/rust/lancedb/src/connection.rs
@@ -1169,6 +1169,7 @@ mod tests {
     use lance_testing::datagen::{BatchGenerator, IncrementingInt32};
     use tempfile::tempdir;
 
+    use crate::query::QueryBase;
     use crate::query::{ExecutableQuery, QueryExecutionOptions};
 
     use super::*;
@@ -1296,6 +1297,7 @@ mod tests {
         // In v1 the row group size will trump max_batch_length
         let batches = tbl
             .query()
+            .limit(20000)
             .execute_with_options(QueryExecutionOptions {
                 max_batch_length: 50000,
                 ..Default::default()
diff --git a/rust/lancedb/src/query.rs b/rust/lancedb/src/query.rs
index 54c344e19..4e3059816 100644
--- a/rust/lancedb/src/query.rs
+++ b/rust/lancedb/src/query.rs
@@ -596,7 +596,7 @@ impl Query {
     pub(crate) fn new(parent: Arc<dyn TableInternal>) -> Self {
         Self {
             parent,
-            limit: None,
+            limit: Some(DEFAULT_TOP_K),
             offset: None,
             filter: None,
             full_text_search: None,
diff --git a/rust/lancedb/src/remote/table.rs b/rust/lancedb/src/remote/table.rs
index 11dbee1b3..c8ce2ec4a 100644
--- a/rust/lancedb/src/remote/table.rs
+++ b/rust/lancedb/src/remote/table.rs
@@ -1227,6 +1227,7 @@ mod tests {
                 "prefilter": true,
                 "distance_type": "l2",
                 "nprobes": 20,
+                "k": 10,
                 "ef": Option::<usize>::None,
                 "refine_factor": null,
                 "version": null,