From 3c62806b6adcb7e6048c71fb2752d217197c165d Mon Sep 17 00:00:00 2001 From: Beinan Date: Sat, 8 Jun 2024 22:43:41 -0700 Subject: [PATCH] fix(java): the JVM crash when using jdk 8 (#1372) The Optional::isEmpty does not exist in java 8, so we should use isPresent instead --- java/core/lancedb-jni/src/ffi.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/core/lancedb-jni/src/ffi.rs b/java/core/lancedb-jni/src/ffi.rs index 387c18a5..b9684b09 100644 --- a/java/core/lancedb-jni/src/ffi.rs +++ b/java/core/lancedb-jni/src/ffi.rs @@ -175,8 +175,8 @@ impl JNIEnvExt for JNIEnv<'_> { if obj.is_null() { return Ok(None); } - let is_empty = self.call_method(obj, "isEmpty", "()Z", &[])?; - if is_empty.z()? { + let is_present = self.call_method(obj, "isPresent", "()Z", &[])?; + if !is_present.z()? { // TODO(lu): put get java object into here cuz can only get java Object Ok(None) } else {