From 56c4b3a6f2886b62e246e0a04da89ddf002dd7a8 Mon Sep 17 00:00:00 2001 From: Xuanwo Date: Sat, 14 Nov 2026 20:55:23 +0800 Subject: [PATCH] ci: stabilize macOS Node toolchain and build budget (#5017) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The macOS Node job installed floating stable before restoring the Rust cache, although native builds use the repository-pinned compiler. Use the existing file-aware Rust setup action with its implicit cache disabled so setup, cache selection and compilation use the same pin and one cache owner. Preserve the existing native build flags. Allow 35 minutes for the complete macOS job. In the [pinned-toolchain cold run](https://github.com/lancedb/lancedb/actions/runs/43291714333/job/131439350321), native compilation finished in 28m02s, but setup and packaging exhausted the former 30-minute job limit before TypeScript checking and Jest. Retained full Jest runs took 38–59 seconds; the new bound covers the measured work with a small margin. The runner, build profile, features, targets and complete test commands are preserved. Hosted acceptance at `ff718c03`: the [complete macOS job](https://github.com/lancedb/lancedb/actions/runs/43300424344/job/131469805138) succeeded within the 35-minute limit (20:27:07–20:56:58 UTC). Native compilation took 27m38s; the complete applicable Jest suite passed 1,695 tests, with 22 skipped, in 46.129s. This single successful run does not guarantee every cold-build duration, validate the separate beta19 composition, or establish the cause of the DynamoDB timeout. --- .github/workflows/nodejs.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index e83c8d29f..4d28ca4a1 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -234,7 +234,8 @@ jobs: NODE_OPTIONS: "--experimental-vm-modules" run: node_modules/.bin/jest --verbose macos: - timeout-minutes: 30 + # Cold native builds can take 28 minutes; reserve time for setup and Jest. + timeout-minutes: 35 # macos-15 ships a newer linker; the older macos-14 linker fails to insert # branch islands when the debug cdylib's __text section exceeds the 128 MB # AArch64 B/BL branch range. @@ -257,7 +258,11 @@ jobs: node-version: 24 cache: 'pnpm' cache-dependency-path: nodejs/pnpm-lock.yaml - - uses: dtolnay/rust-toolchain@stable + # Use the same pinned compiler for cache selection and the native build. + - uses: actions-rust-lang/setup-rust-toolchain@v1 + with: + cache: false + rustflags: "" - uses: Swatinem/rust-cache@v2 with: # Restore everywhere, but only save from main. Per-PR saves are