feat: upgrade Lance to 3.0.0-rc.3 (#3104)

Co-authored-by: Jack Ye <yezhaoqin@gmail.com>

python/src/namespace.rs

@@ -96,10 +96,10 @@ where
     Resp: serde::de::DeserializeOwned + Send + 'static,
 {
     let request_json = serde_json::to_string(&request).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to serialize request for {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to serialize request for {}: {}",
+            method_name, e
+        ))
     })?;
 
     let response_json = tokio::task::spawn_blocking(move || {
@@ -128,24 +128,14 @@ where
         })
     })
     .await
-    .map_err(|e| {
-        lance_core::Error::io(
-            format!("Task join error for {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?
-    .map_err(|e: PyErr| {
-        lance_core::Error::io(
-            format!("Python error in {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?;
+    .map_err(|e| lance_core::Error::io(format!("Task join error for {}: {}", method_name, e)))?
+    .map_err(|e: PyErr| lance_core::Error::io(format!("Python error in {}: {}", method_name, e)))?;
 
     serde_json::from_str(&response_json).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to deserialize response from {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to deserialize response from {}: {}",
+            method_name, e
+        ))
     })
 }
 
@@ -159,10 +149,10 @@ where
     Req: serde::Serialize + Send + 'static,
 {
     let request_json = serde_json::to_string(&request).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to serialize request for {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to serialize request for {}: {}",
+            method_name, e
+        ))
     })?;
 
     tokio::task::spawn_blocking(move || {
@@ -180,18 +170,8 @@ where
         })
     })
     .await
-    .map_err(|e| {
-        lance_core::Error::io(
-            format!("Task join error for {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?
-    .map_err(|e: PyErr| {
-        lance_core::Error::io(
-            format!("Python error in {}: {}", method_name, e),
-            Default::default(),
-        )
-    })
+    .map_err(|e| lance_core::Error::io(format!("Task join error for {}: {}", method_name, e)))?
+    .map_err(|e: PyErr| lance_core::Error::io(format!("Python error in {}: {}", method_name, e)))
 }
 
 /// Helper for methods that return a primitive type
@@ -205,10 +185,10 @@ where
     Resp: for<'py> pyo3::FromPyObject<'py> + Send + 'static,
 {
     let request_json = serde_json::to_string(&request).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to serialize request for {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to serialize request for {}: {}",
+            method_name, e
+        ))
     })?;
 
     tokio::task::spawn_blocking(move || {
@@ -227,18 +207,8 @@ where
         })
     })
     .await
-    .map_err(|e| {
-        lance_core::Error::io(
-            format!("Task join error for {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?
-    .map_err(|e: PyErr| {
-        lance_core::Error::io(
-            format!("Python error in {}: {}", method_name, e),
-            Default::default(),
-        )
-    })
+    .map_err(|e| lance_core::Error::io(format!("Task join error for {}: {}", method_name, e)))?
+    .map_err(|e: PyErr| lance_core::Error::io(format!("Python error in {}: {}", method_name, e)))
 }
 
 /// Helper for methods that return Bytes
@@ -251,10 +221,10 @@ where
     Req: serde::Serialize + Send + 'static,
 {
     let request_json = serde_json::to_string(&request).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to serialize request for {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to serialize request for {}: {}",
+            method_name, e
+        ))
     })?;
 
     tokio::task::spawn_blocking(move || {
@@ -273,18 +243,8 @@ where
         })
     })
     .await
-    .map_err(|e| {
-        lance_core::Error::io(
-            format!("Task join error for {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?
-    .map_err(|e: PyErr| {
-        lance_core::Error::io(
-            format!("Python error in {}: {}", method_name, e),
-            Default::default(),
-        )
-    })
+    .map_err(|e| lance_core::Error::io(format!("Task join error for {}: {}", method_name, e)))?
+    .map_err(|e: PyErr| lance_core::Error::io(format!("Python error in {}: {}", method_name, e)))
 }
 
 /// Helper for methods that take request + data and return a response
@@ -299,10 +259,10 @@ where
     Resp: serde::de::DeserializeOwned + Send + 'static,
 {
     let request_json = serde_json::to_string(&request).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to serialize request for {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to serialize request for {}: {}",
+            method_name, e
+        ))
     })?;
 
     let response_json = tokio::task::spawn_blocking(move || {
@@ -324,24 +284,14 @@ where
         })
     })
     .await
-    .map_err(|e| {
-        lance_core::Error::io(
-            format!("Task join error for {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?
-    .map_err(|e: PyErr| {
-        lance_core::Error::io(
-            format!("Python error in {}: {}", method_name, e),
-            Default::default(),
-        )
-    })?;
+    .map_err(|e| lance_core::Error::io(format!("Task join error for {}: {}", method_name, e)))?
+    .map_err(|e: PyErr| lance_core::Error::io(format!("Python error in {}: {}", method_name, e)))?;
 
     serde_json::from_str(&response_json).map_err(|e| {
-        lance_core::Error::io(
-            format!("Failed to deserialize response from {}: {}", method_name, e),
-            Default::default(),
-        )
+        lance_core::Error::io(format!(
+            "Failed to deserialize response from {}: {}",
+            method_name, e
+        ))
     })
 }
 

python/src/storage_options.rs

@@ -66,13 +66,10 @@ impl StorageOptionsProvider for PyStorageOptionsProviderWrapper {
                     .inner
                     .bind(py)
                     .call_method0("fetch_storage_options")
-                    .map_err(|e| lance_core::Error::IO {
-                        source: Box::new(std::io::Error::other(format!(
-                            "Failed to call fetch_storage_options: {}",
-                            e
-                        ))),
-                        location: snafu::location!(),
-                    })?;
+                    .map_err(|e| lance_core::Error::io_source(Box::new(std::io::Error::other(format!(
+                        "Failed to call fetch_storage_options: {}",
+                        e
+                    )))))?;
 
                 // If result is None, return None
                 if result.is_none() {
@@ -81,26 +78,19 @@ impl StorageOptionsProvider for PyStorageOptionsProviderWrapper {
 
                 // Extract the result dict - should be a flat Map<String, String>
                 let result_dict = result.downcast::<PyDict>().map_err(|_| {
-                    lance_core::Error::InvalidInput {
-                        source: "fetch_storage_options() must return None or a dict of string key-value pairs".into(),
-                        location: snafu::location!(),
-                    }
+                    lance_core::Error::invalid_input(
+                        "fetch_storage_options() must return a dict of string key-value pairs or None",
+                    )
                 })?;
 
                 // Convert all entries to HashMap<String, String>
                 let mut storage_options = HashMap::new();
                 for (key, value) in result_dict.iter() {
                     let key_str: String = key.extract().map_err(|e| {
-                        lance_core::Error::InvalidInput {
-                            source: format!("Storage option key must be a string: {}", e).into(),
-                            location: snafu::location!(),
-                        }
+                        lance_core::Error::invalid_input(format!("Storage option key must be a string: {}", e))
                     })?;
                     let value_str: String = value.extract().map_err(|e| {
-                        lance_core::Error::InvalidInput {
-                            source: format!("Storage option value must be a string: {}", e).into(),
-                            location: snafu::location!(),
-                        }
+                        lance_core::Error::invalid_input(format!("Storage option value must be a string: {}", e))
                     })?;
                     storage_options.insert(key_str, value_str);
                 }
@@ -109,13 +99,10 @@ impl StorageOptionsProvider for PyStorageOptionsProviderWrapper {
             })
         })
         .await
-        .map_err(|e| lance_core::Error::IO {
-            source: Box::new(std::io::Error::other(format!(
-                "Task join error: {}",
-                e
-            ))),
-            location: snafu::location!(),
-        })?
+        .map_err(|e| lance_core::Error::io_source(Box::new(std::io::Error::other(format!(
+            "Task join error: {}",
+            e
+        )))))?
     }
 
     fn provider_id(&self) -> String {