diff --git a/python/python/lancedb/table.py b/python/python/lancedb/table.py index 9d951f559..11ca7de84 100644 --- a/python/python/lancedb/table.py +++ b/python/python/lancedb/table.py @@ -6925,9 +6925,11 @@ class AsyncTable: """ versions = await self._inner.list_versions() for v in versions: - ts_nanos = v["timestamp"] - v["timestamp"] = datetime.fromtimestamp(ts_nanos // 1e9) + timedelta( - microseconds=(ts_nanos % 1e9) // 1e3 + # Use integer math: float division on ~1e18 nanosecond + # values loses sub-millisecond precision. + seconds, nanos = divmod(v["timestamp"], 1_000_000_000) + v["timestamp"] = datetime.fromtimestamp(seconds) + timedelta( + microseconds=nanos // 1000 ) return versions diff --git a/python/python/tests/test_table.py b/python/python/tests/test_table.py index e5ee3c3a2..64f4f4ce9 100644 --- a/python/python/tests/test_table.py +++ b/python/python/tests/test_table.py @@ -993,6 +993,63 @@ def test_polars(mem_db: DBConnection): assert len(filtered_result) == 2 +@pytest.mark.asyncio +async def test_list_versions_timestamp_precision(): + # 2026-10-03T01:03:49.274Z in nanoseconds. Float math turns .274000 into + # .273999, so make sure the conversion is exact. + ts_nanos = 1790989429274000000 + + class FakeInner: + async def list_versions(self): + return [{"version": 1, "timestamp": ts_nanos, "metadata": {}}] + + table = table_module.AsyncTable(FakeInner()) + versions = await table.list_versions() + + expected = datetime.fromtimestamp(ts_nanos // 1_000_000_000) + assert versions[0]["timestamp"] == expected + timedelta(microseconds=274000) + assert versions[0]["timestamp"].microsecond == 274000 + + +def test_list_versions_timestamp_precision_sync(mem_db: DBConnection): + # The sync LanceTable.list_versions delegates to AsyncTable.list_versions, + # which is the path the parity report hit. + ts_nanos = 1790989429274000000 + + class FakeInner: + async def list_versions(self): + return [{"version": 1, "timestamp": ts_nanos, "metadata": {}}] + + table = mem_db.create_table("ts_precision", data=[{"id": 1}]) + table._table = table_module.AsyncTable(FakeInner()) + versions = table.list_versions() + + expected = datetime.fromtimestamp(ts_nanos // 1_000_000_000) + assert versions[0]["timestamp"] == expected + timedelta(microseconds=274000) + assert versions[0]["timestamp"].microsecond == 274000 + + +def test_list_versions_timestamp_precision_remote(): + # RemoteTable.list_versions also delegates to AsyncTable.list_versions. + from lancedb.remote.table import RemoteTable + + ts_nanos = 1790989429274000000 + + class FakeInner: + def name(self): + return "ts_precision" + + async def list_versions(self): + return [{"version": 1, "timestamp": ts_nanos, "metadata": {}}] + + table = RemoteTable(table_module.AsyncTable(FakeInner()), "dev") + versions = table.list_versions() + + expected = datetime.fromtimestamp(ts_nanos // 1_000_000_000) + assert versions[0]["timestamp"] == expected + timedelta(microseconds=274000) + assert versions[0]["timestamp"].microsecond == 274000 + + def test_versioning(mem_db: DBConnection): table = mem_db.create_table( "test",