rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-11-13 14:16:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(python): align catalog and database connection inputs (#4983)

Browse Source 
Align Python catalog connection inputs with database connections, warn when region is ignored, and preserve remote storage settings in opened databases.
This commit is contained in:
Jack Ye
2026-11-12 01:19:05 -08:00
committed by GitHub
parent 478d1d9b01
commit 7b2dfb9e36
10 changed files with 389 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/catalog.rs
+7 -1
View File
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: Copyright The LanceDB Authors
use std::collections::HashMap;
use std::sync::{Arc, Mutex};
use std::time::Duration;
@@ -127,7 +128,8 @@ impl DatabaseNames {
}
#[pyfunction]
#[pyo3(signature = (endpoint, *, api_key=None, client_config=None, sql_host_override=None, read_consistency_interval=None, oauth_config=None))]
#[allow(clippy::too_many_arguments)]
#[pyo3(signature = (endpoint, *, api_key=None, client_config=None, sql_host_override=None, read_consistency_interval=None, oauth_config=None, storage_options=None))]
pub fn connect_catalog(
py: Python<'_>,
endpoint: String,
@@ -136,6 +138,7 @@ pub fn connect_catalog(
sql_host_override: Option<String>,
read_consistency_interval: Option<f64>,
oauth_config: Option<crate::oauth::PyOAuthConfig>,
storage_options: Option<HashMap<String, String>>,
) -> PyResult<Bound<'_, PyAny>> {
let interval = read_consistency_interval
.map(Duration::try_from_secs_f64)
@@ -151,6 +154,9 @@ pub fn connect_catalog(
if let Some(config) = client_config {
builder = builder.client_config(config.into());
}
if let Some(options) = storage_options {
builder = builder.storage_options(options);
}
if let Some(endpoint) = sql_host_override {
builder = builder.sql_host_override(endpoint);
}