From 7bf020b3d530fe9d3bd418f49900f3251a805505 Mon Sep 17 00:00:00 2001 From: Jack Ye Date: Mon, 26 Jan 2026 13:59:31 -0800 Subject: [PATCH] chore: fix clippy when remote flag is not set (#2943) Also add a step in CI to ensure this does not happen in the future --- .github/workflows/rust.yml | 2 ++ rust/lancedb/src/connection.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 8fab085d6..b5aa641a7 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -48,6 +48,8 @@ jobs: run: cargo fmt --all -- --check - name: Run clippy run: cargo clippy --profile ci --workspace --tests --all-features -- -D warnings + - name: Run clippy (without remote feature) + run: cargo clippy --profile ci --workspace --tests -- -D warnings build-no-lock: runs-on: ubuntu-24.04 diff --git a/rust/lancedb/src/connection.rs b/rust/lancedb/src/connection.rs index 9078f3873..cd2c02394 100644 --- a/rust/lancedb/src/connection.rs +++ b/rust/lancedb/src/connection.rs @@ -892,6 +892,7 @@ pub struct ConnectBuilder { embedding_registry: Option>, } +#[cfg(feature = "remote")] const ENV_VARS_TO_STORAGE_OPTS: [(&str, &str); 1] = [("AZURE_STORAGE_ACCOUNT_NAME", "azure_storage_account_name")];