From 8687735bea6f7c0726e307d6096845f1b44bf84b Mon Sep 17 00:00:00 2001
From: Lei Xu <lei@lancedb.com>
Date: Wed, 3 Apr 2024 16:52:32 -0700
Subject: [PATCH] chore: bump to 0.10.8 (#1187)

---
 Cargo.toml                | 8 ++++----
 python/pyproject.toml     | 2 +-
 rust/lancedb/src/table.rs | 9 +--------
 3 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index a3dd106b..6ed9640c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -14,10 +14,10 @@ keywords = ["lancedb", "lance", "database", "vector", "search"]
 categories = ["database-implementations"]
 
 [workspace.dependencies]
-lance = { "version" = "=0.10.7", "features" = ["dynamodb"] }
-lance-index = { "version" = "=0.10.7" }
-lance-linalg = { "version" = "=0.10.7" }
-lance-testing = { "version" = "=0.10.7" }
+lance = { "version" = "=0.10.8", "features" = ["dynamodb"] }
+lance-index = { "version" = "=0.10.8" }
+lance-linalg = { "version" = "=0.10.8" }
+lance-testing = { "version" = "=0.10.8" }
 # Note that this one does not include pyarrow
 arrow = { version = "50.0", optional = false }
 arrow-array = "50.0"
diff --git a/python/pyproject.toml b/python/pyproject.toml
index e187e67c..ca212301 100644
--- a/python/pyproject.toml
+++ b/python/pyproject.toml
@@ -3,7 +3,7 @@ name = "lancedb"
 version = "0.6.6"
 dependencies = [
     "deprecation",
-    "pylance==0.10.7",
+    "pylance==0.10.8",
     "ratelimiter~=1.0",
     "retry>=0.9.2",
     "tqdm>=4.27.0",
diff --git a/rust/lancedb/src/table.rs b/rust/lancedb/src/table.rs
index e3e3ab2d..7331e29c 100644
--- a/rust/lancedb/src/table.rs
+++ b/rust/lancedb/src/table.rs
@@ -1304,14 +1304,7 @@ impl TableInternal for NativeTable {
     }
 
     async fn count_rows(&self, filter: Option<String>) -> Result<usize> {
-        let dataset = self.dataset.get().await?;
-        if let Some(filter) = filter {
-            let mut scanner = dataset.scan();
-            scanner.filter(&filter)?;
-            Ok(scanner.count_rows().await? as usize)
-        } else {
-            Ok(dataset.count_rows().await?)
-        }
+        Ok(self.dataset.get().await?.count_rows(filter).await?)
     }
 
     async fn add(