From 86d3f23f538190f7161f3b417f5789f1045b67ec Mon Sep 17 00:00:00 2001 From: Lu Qiu Date: Fri, 31 Jul 2026 17:45:27 -0400 Subject: [PATCH] chore: keep remote write types crate-visible --- rust/lancedb/src/remote/table.rs | 2 +- rust/lancedb/src/remote/table/insert.rs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/lancedb/src/remote/table.rs b/rust/lancedb/src/remote/table.rs index 9a08352c6..e9c200521 100644 --- a/rust/lancedb/src/remote/table.rs +++ b/rust/lancedb/src/remote/table.rs @@ -2939,7 +2939,7 @@ impl BaseTable for RemoteTable { } #[derive(Serialize, Clone, Debug)] -pub struct MergeInsertRequest { +pub(crate) struct MergeInsertRequest { on: String, when_matched_update_all: bool, when_matched_update_all_filt: Option, diff --git a/rust/lancedb/src/remote/table/insert.rs b/rust/lancedb/src/remote/table/insert.rs index a4a28a9c6..67ea7765d 100644 --- a/rust/lancedb/src/remote/table/insert.rs +++ b/rust/lancedb/src/remote/table/insert.rs @@ -33,7 +33,7 @@ use crate::table::{AddResult, MergeResult}; /// same Arrow-IPC streaming body and error side-channel; only the target /// endpoint, query parameters, and parsed result type differ. #[derive(Debug, Clone)] -pub enum WriteOp { +pub(crate) enum WriteOp { /// `add`: stream to `/v1/table/{id}/insert/`, optionally overwriting. Insert { overwrite: bool }, /// `merge_insert`: stream to `/v1/table/{id}/merge_insert/` with the merge @@ -49,7 +49,7 @@ pub enum WriteOp { /// The parsed server response for a completed write, discriminated by the /// operation that produced it. #[derive(Debug, Clone)] -pub enum WriteResult { +pub(crate) enum WriteResult { Add(AddResult), Merge(MergeResult), }