rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-10-23 12:12:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: return errors for unsupported remote alteration types

Browse Source
This commit is contained in:
Xucheng Zhou
2026-10-04 11:13:35 +08:00
parent 0be3ae960e
commit 88184ea3da
1 changed files with 32 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rust/lancedb/src/remote/table.rs
+32 -5
View File
@@ -3626,16 +3626,25 @@ impl<S: HttpSend> BaseTable for RemoteTable<S> {
value["rename"] = serde_json::Value::String(rename.clone());
}
if let Some(data_type) = &alteration.data_type {
let json_data_type = JsonDataType::try_from(data_type).unwrap();
let json_data_type = serde_json::to_value(&json_data_type).unwrap();
value["data_type"] = json_data_type;
let json_data_type =
JsonDataType::try_from(data_type).map_err(|err| Error::InvalidInput {
message: format!(
"Cannot serialize data type for column '{}': {err}",
alteration.path
),
})?;
value["data_type"] = serde_json::to_value(&json_data_type).map_err(|err| {
Error::InvalidInput {
message: format!("Cannot serialize column alteration: {err}"),
}
})?;
}
if let Some(nullable) = &alteration.nullable {
value["nullable"] = serde_json::Value::Bool(*nullable);
}
value
Ok(value)
})
.collect::<Vec<_>>();
.collect::<Result<Vec<_>>>()?;
let mut body = serde_json::json!({ "alterations": body });
self.apply_branch_body(&mut body);
let request = self
@@ -4713,6 +4722,24 @@ mod tests {
}
}
#[rstest]
#[case::string_view(DataType::Utf8View)]
#[case::binary_view(DataType::BinaryView)]
#[case::nested_view(DataType::Struct(vec![Field::new("value", DataType::Utf8View, true)].into()))]
#[tokio::test]
async fn test_alter_columns_unsupported_type(#[case] data_type: DataType) {
let table = Table::new_with_handler("my_table", |_| -> http::Response<String> {
panic!("an unserializable alteration must not reach the server")
});
let err = table
.alter_columns(&[ColumnAlteration::new("value".into()).cast_to(data_type)])
.await
.unwrap_err();
assert!(matches!(err, Error::InvalidInput { .. }), "got {err:?}");
assert!(err.to_string().contains("value"));
assert!(err.to_string().contains("Unsupported type"));
}
#[rstest]
#[case(true)]
#[case(false)]