From 8ea06fe7f3dfa5164129bb18f626ee56a32dc471 Mon Sep 17 00:00:00 2001 From: Will Jones Date: Wed, 10 Apr 2024 13:09:39 -0700 Subject: [PATCH] ci: fix failures in release scripts (#1215) * Python release has been running when we create a Node release. https://github.com/lancedb/lancedb/actions/runs/8635662585 * Rust is missing new enough compilers to check the kernels feature https://github.com/lancedb/lancedb/actions/runs/8635662578 --- .github/workflows/cargo-publish.yml | 3 +++ .github/workflows/pypi-publish.yml | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/.github/workflows/cargo-publish.yml b/.github/workflows/cargo-publish.yml index 9e4dfd35..50cdd125 100644 --- a/.github/workflows/cargo-publish.yml +++ b/.github/workflows/cargo-publish.yml @@ -8,6 +8,9 @@ env: # This env var is used by Swatinem/rust-cache@v2 for the cache # key, so we set it to make sure it is always consistent. CARGO_TERM_COLOR: always + # Up-to-date compilers needed for fp16kernels. + CC: gcc-12 + CXX: g++-12 jobs: build: diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml index aacd5848..c913003d 100644 --- a/.github/workflows/pypi-publish.yml +++ b/.github/workflows/pypi-publish.yml @@ -6,6 +6,8 @@ on: jobs: linux: + # Only runs on tags that matches the python-make-release action + if: startsWith(github.ref, 'refs/tags/python-v') name: Python ${{ matrix.config.platform }} manylinux${{ matrix.config.manylinux }} timeout-minutes: 60 strategy: @@ -44,6 +46,8 @@ jobs: token: ${{ secrets.LANCEDB_PYPI_API_TOKEN }} repo: "pypi" mac: + # Only runs on tags that matches the python-make-release action + if: startsWith(github.ref, 'refs/tags/python-v') timeout-minutes: 60 runs-on: ${{ matrix.config.runner }} strategy: @@ -76,6 +80,8 @@ jobs: token: ${{ secrets.LANCEDB_PYPI_API_TOKEN }} repo: "pypi" windows: + # Only runs on tags that matches the python-make-release action + if: startsWith(github.ref, 'refs/tags/python-v') timeout-minutes: 60 runs-on: windows-latest strategy: