From 93354baf34ebe4af46aebd50ea02d27f44abc4e3 Mon Sep 17 00:00:00 2001 From: Will Jones Date: Fri, 31 Jul 2026 16:40:58 -0700 Subject: [PATCH] chore: upgrade rust toolchain to 1.97.0 (#3643) Bumps the pinned Rust toolchain from 1.95.0 to the latest stable (1.97.0). Rust 1.97's clippy adds `useless_borrows_in_formatting`, which flags a redundant `&` in `format!`/`debug!` arguments in a few places. This PR removes those to keep `cargo clippy` clean. No behavior change; the MSRV (`rust-version = "1.91.0"`) is unchanged. Co-authored-by: Claude Opus 4.8 (1M context) --- rust-toolchain.toml | 2 +- rust/lancedb/src/embeddings.rs | 6 +++--- rust/lancedb/src/remote/client.rs | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/rust-toolchain.toml b/rust-toolchain.toml index f25b5b140..398f3f015 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,2 +1,2 @@ [toolchain] -channel = "1.95.0" +channel = "1.97.0" diff --git a/rust/lancedb/src/embeddings.rs b/rust/lancedb/src/embeddings.rs index 58e037bdd..469c25b4a 100644 --- a/rust/lancedb/src/embeddings.rs +++ b/rust/lancedb/src/embeddings.rs @@ -264,7 +264,7 @@ pub fn compute_output_schema( let field_name = ed .dest_column .clone() - .unwrap_or_else(|| format!("{}_embedding", &ed.source_column)); + .unwrap_or_else(|| format!("{}_embedding", ed.source_column)); sb.push(Field::new( field_name, @@ -291,7 +291,7 @@ pub fn compute_embeddings_for_batch( let dst_field_name = fld .dest_column .clone() - .unwrap_or_else(|| format!("{}_embedding", &fld.source_column)); + .unwrap_or_else(|| format!("{}_embedding", fld.source_column)); let dst_field = Field::new( dst_field_name, @@ -315,7 +315,7 @@ impl WithEmbeddings { let field_name = ed .dest_column .clone() - .unwrap_or_else(|| format!("{}_embedding", &ed.source_column)); + .unwrap_or_else(|| format!("{}_embedding", ed.source_column)); Ok(Field::new( field_name, func.dest_type()?.into_owned(), diff --git a/rust/lancedb/src/remote/client.rs b/rust/lancedb/src/remote/client.rs index 2f4ac03d3..9e34fca9f 100644 --- a/rust/lancedb/src/remote/client.rs +++ b/rust/lancedb/src/remote/client.rs @@ -706,7 +706,7 @@ impl RestfulLanceDbClient { .err_to_http(request_id.clone())?; debug!( "Received response for request_id={}: {:?}", - request_id, &response + request_id, response ); Ok((request_id, response)) } @@ -768,7 +768,7 @@ impl RestfulLanceDbClient { Ok((status, response)) if status.is_success() => { debug!( "Received response for request_id={}: {:?}", - retry_counter.request_id, &response + retry_counter.request_id, response ); return Ok((retry_counter.request_id, response)); }