mirror of
https://github.com/lancedb/lancedb.git
synced 2026-10-28 06:26:15 +00:00
fix(python): accept with_row_id in take_offsets/take_row_ids on every Table implementation (#4374)
`Table.take_offsets` and `Table.take_row_ids` declare a keyword-only `with_row_id: bool = False`, but none of the three implementations accept it — `LanceTable`, `AsyncTable` and `RemoteTable` all raise `TypeError: ... got an unexpected keyword argument 'with_row_id'` on the documented call. The builders they return already support it (`LanceTakeQueryBuilder.with_row_id()` / `AsyncTakeQuery.with_row_id()`), so this is a signature that never reached the implementations. The base docstrings also don't mention the parameter and still say `take_offsets` returns a `pa.RecordBatch` (it returns a `LanceTakeQueryBuilder`), so those are corrected too. Each implementation now accepts the kwarg and applies `.with_row_id()` to the builder it returns. Tests: sync and async assert `_rowid` appears in the result columns; the remote test uses the suite's request-capturing fixture and asserts `with_row_id: true` reaches the wire (and is absent by default). All three fail on `main` with the `TypeError`. ruff format/check clean. A related mismatch I left alone: the deprecated `LanceTable.create_scalar_index`/`create_fts_index` also drop a `wait_timeout` the base declares — deprecated since 0.25, so not worth touching here. Co-authored-by: Xuanwo <github@xuanwo.io>
This commit is contained in:
co-authored by
Xuanwo
parent
3321860e9f
commit
9da4658d57
@@ -2225,6 +2225,23 @@ def test_head():
|
||||
assert data == pa.table({"id": [1, 2, 3]})
|
||||
|
||||
|
||||
def test_remote_take_row_ids_with_row_id():
|
||||
bodies = []
|
||||
|
||||
def handler(body):
|
||||
bodies.append(body)
|
||||
return pa.table({"id": [1, 2], "_rowid": pa.array([0, 1], pa.uint64())})
|
||||
|
||||
with query_test_table(handler) as table:
|
||||
result = table.take_row_ids([0, 1], with_row_id=True).to_arrow()
|
||||
assert "_rowid" in result.column_names
|
||||
assert bodies[-1]["with_row_id"] is True
|
||||
|
||||
with query_test_table(handler) as table:
|
||||
table.take_row_ids([0, 1]).to_arrow()
|
||||
assert "with_row_id" not in bodies[-1]
|
||||
|
||||
|
||||
def test_query_sync_minimal():
|
||||
def handler(body):
|
||||
assert body == {
|
||||
|
||||
Reference in New Issue
Block a user