From a6babfa651696a7a0cdd050234a8ccdd9e6946ea Mon Sep 17 00:00:00 2001 From: Will Jones Date: Tue, 7 May 2024 10:16:05 -0700 Subject: [PATCH] fix(node/vectordb): parse value not key (#1276) --- node/src/integration_test/test.ts | 2 +- rust/ffi/node/src/lib.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/node/src/integration_test/test.ts b/node/src/integration_test/test.ts index 7a09db67..0fd84406 100644 --- a/node/src/integration_test/test.ts +++ b/node/src/integration_test/test.ts @@ -51,7 +51,7 @@ describe('LanceDB Mirrored Store Integration test', function () { const dir = tmpdir() console.log(dir) - const conn = await lancedb.connect(`s3://lancedb-integtest?mirroredStore=${dir}`) + const conn = await lancedb.connect({ uri: `s3://lancedb-integtest?mirroredStore=${dir}`, storageOptions: { allowHttp: 'true' } }) const data = Array(200).fill({ vector: Array(128).fill(1.0), id: 0 }) data.push(...Array(200).fill({ vector: Array(128).fill(1.0), id: 1 })) data.push(...Array(200).fill({ vector: Array(128).fill(1.0), id: 2 })) diff --git a/rust/ffi/node/src/lib.rs b/rust/ffi/node/src/lib.rs index 26afc78b..54223255 100644 --- a/rust/ffi/node/src/lib.rs +++ b/rust/ffi/node/src/lib.rs @@ -59,7 +59,7 @@ fn database_new(mut cx: FunctionContext) -> JsResult { for handle in storage_options_js { let obj = handle.downcast::(&mut cx).unwrap(); let key = obj.get::(&mut cx, 0)?.value(&mut cx); - let value = obj.get::(&mut cx, 0)?.value(&mut cx); + let value = obj.get::(&mut cx, 1)?.value(&mut cx); storage_options.push((key, value)); }