fix: revert change default read_consistency_interval=5s (#2327)

This reverts commit a547c523c2 or #2281

The current implementation can cause panics and performance degradation.
I will bring this back with more testing in
https://github.com/lancedb/lancedb/pull/2311

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Enhanced clarity on read consistency settings with updated
descriptions and default behavior.
- Removed outdated warnings about eventual consistency from the
troubleshooting guide.

- **Refactor**
- Streamlined the handling of the read consistency interval across
integrations, now defaulting to "None" for improved performance.
  - Simplified internal logic to offer a more consistent experience.

- **Tests**
- Updated test expectations to reflect the new default representation
for the read consistency interval.
- Removed redundant tests related to "no consistency" settings for
streamlined testing.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

nodejs/__test__/connection.test.ts

@@ -17,7 +17,7 @@ describe("when connecting", () => {
   it("should connect", async () => {
     const db = await connect(tmpDir.name);
     expect(db.display()).toBe(
-      `ListingDatabase(uri=${tmpDir.name}, read_consistency_interval=5s)`,
+      `ListingDatabase(uri=${tmpDir.name}, read_consistency_interval=None)`,
     );
   });
 

nodejs/__test__/table.test.ts

@@ -58,7 +58,7 @@ describe.each([arrow15, arrow16, arrow17, arrow18])(
 
     it("be displayable", async () => {
       expect(table.display()).toMatch(
-        /NativeTable\(some_table, uri=.*, read_consistency_interval=5s\)/,
+        /NativeTable\(some_table, uri=.*, read_consistency_interval=None\)/,
       );
       table.close();
       expect(table.display()).toBe("ClosedTable(some_table)");

nodejs/examples/basic.test.ts

@@ -202,35 +202,5 @@ test("basic table examples", async () => {
       // --8<-- [end:create_f16_table]
       await db.dropTable("f16_tbl");
     }
-    const uri = databaseDir;
-    await db.createTable("my_table", [{ id: 1 }, { id: 2 }]);
-    {
-      // --8<-- [start:table_strong_consistency]
-      const db = await lancedb.connect({ uri, readConsistencyInterval: 0 });
-      const tbl = await db.openTable("my_table");
-      // --8<-- [end:table_strong_consistency]
-    }
-    {
-      // --8<-- [start:table_eventual_consistency]
-      const db = await lancedb.connect({ uri, readConsistencyInterval: 5 });
-      const tbl = await db.openTable("my_table");
-      // --8<-- [end:table_eventual_consistency]
-    }
-    {
-      // --8<-- [start:table_no_consistency]
-      const db = await lancedb.connect({ uri, readConsistencyInterval: null });
-      const tbl = await db.openTable("my_table");
-      // --8<-- [end:table_no_consistency]
-    }
-    {
-      // --8<-- [start:table_checkout_latest]
-      const tbl = await db.openTable("my_table");
-
-      // (Other writes happen to test_table_async from another process)
-
-      // Check for updates
-      tbl.checkoutLatest();
-      // --8<-- [end:table_checkout_latest]
-    }
   });
 });

nodejs/src/connection.rs

@@ -48,16 +48,8 @@ impl Connection {
     pub async fn new(uri: String, options: ConnectionOptions) -> napi::Result<Self> {
         let mut builder = ConnectBuilder::new(&uri);
         if let Some(interval) = options.read_consistency_interval {
-            match interval {
-                Either::A(seconds) => {
-                    builder = builder.read_consistency_interval(Some(
-                        std::time::Duration::from_secs_f64(seconds),
-                    ));
-                }
-                Either::B(_) => {
-                    builder = builder.read_consistency_interval(None);
-                }
-            }
+            builder =
+                builder.read_consistency_interval(std::time::Duration::from_secs_f64(interval));
         }
         if let Some(storage_options) = options.storage_options {
             for (key, value) in storage_options {

nodejs/src/lib.rs

@@ -4,7 +4,6 @@
 use std::collections::HashMap;
 
 use env_logger::Env;
-use napi::{bindgen_prelude::Null, Either};
 use napi_derive::*;
 
 mod connection;
@@ -19,6 +18,7 @@ mod table;
 mod util;
 
 #[napi(object)]
+#[derive(Debug)]
 pub struct ConnectionOptions {
     /// (For LanceDB OSS only): The interval, in seconds, at which to check for
     /// updates to the table from other processes. If None, then consistency is not
@@ -29,7 +29,7 @@ pub struct ConnectionOptions {
     /// has passed since the last check, then the table will be checked for updates.
     /// Note: this consistency only applies to read operations. Write operations are
     /// always consistent.
-    pub read_consistency_interval: Option<Either<f64, Null>>,
+    pub read_consistency_interval: Option<f64>,
     /// (For LanceDB OSS only): configuration for object storage.
     ///
     /// The available options are described at https://lancedb.github.io/lancedb/guides/storage/