From b8447000713dac3e62b19cf4c7eaa16b58edb038 Mon Sep 17 00:00:00 2001 From: Wyatt Alt Date: Tue, 6 Oct 2026 11:46:19 +0000 Subject: [PATCH] chore: raise MSRV to 1.94.0 for lance 14 lance 14.0.0-beta.1 requires rustc 1.94.0. The 1.91.0 dependency downgrades in the MSRV job no longer apply; only aws-smithy-types needs pinning, since 1.6.1+ requires 1.94.1. --- .github/workflows/rust.yml | 39 ++++---------------------------------- Cargo.toml | 2 +- python/Cargo.toml | 2 +- 3 files changed, 6 insertions(+), 37 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 585abf5ee..cbfefc83d 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -285,7 +285,7 @@ jobs: runs-on: ubuntu-24.04 strategy: matrix: - msrv: ["1.91.0"] # This should match up with rust-version in Cargo.toml + msrv: ["1.94.0"] # This should match up with rust-version in Cargo.toml env: # Need up-to-date compilers for kernels CC: clang-18 @@ -308,40 +308,9 @@ jobs: # unreadable outside their own branch anyway, since GitHub scopes # caches to the creating ref. save-if: ${{ github.ref == 'refs/heads/main' }} - - name: Downgrade dependencies - # These packages have newer requirements for MSRV - run: | - cargo update -p aws-sdk-bedrockruntime --precise 1.77.0 - cargo update -p aws-sdk-dynamodb --precise 1.68.0 - cargo update -p aws-config --precise 1.6.0 - cargo update -p aws-sdk-kms --precise 1.63.0 - cargo update -p aws-sdk-s3 --precise 1.79.0 - cargo update -p aws-sdk-sso --precise 1.62.0 - cargo update -p aws-sdk-ssooidc --precise 1.63.0 - cargo update -p aws-sdk-sts --precise 1.63.0 - # aws-runtime/sigv4/credential-types/types and the aws-smithy-* - # crates bumped their MSRV to 1.91.1 in late 2026; pin to the last - # 1.91.0-compatible versions. The order matters — each downgrade - # only succeeds once everything that still pins it at a higher - # version has itself been downgraded. - cargo update -p aws-runtime --precise 1.5.12 - cargo update -p aws-types --precise 1.3.9 - cargo update -p aws-sigv4 --precise 1.3.5 - cargo update -p aws-credential-types --precise 1.2.8 - # aws-smithy-checksums must stay at or above 0.63.13: OpenDAL's S3 - # service needs crc-fast ~1.9, and older releases pin it to ~1.3. - cargo update -p aws-smithy-checksums --precise 0.63.13 - cargo update -p aws-smithy-runtime --precise 1.9.3 - cargo update -p aws-smithy-http --precise 0.62.6 - cargo update -p aws-smithy-eventstream --precise 0.60.14 - cargo update -p aws-smithy-http-client --precise 1.1.3 - cargo update -p aws-smithy-observability --precise 0.1.4 - cargo update -p aws-smithy-query --precise 0.60.8 - cargo update -p aws-smithy-runtime-api --precise 1.9.3 - cargo update -p aws-smithy-async --precise 1.2.7 - cargo update -p aws-smithy-types --precise 1.3.6 - cargo update -p aws-smithy-xml --precise 0.60.11 - cargo update -p home --precise 0.5.9 + - name: Downgrade dependencies + # aws-smithy-types 1.6.1+ requires rustc 1.94.1 + run: cargo update -p aws-smithy-types --precise 1.5.0 - name: cargo +${{ matrix.msrv }} check env: RUSTUP_TOOLCHAIN: ${{ matrix.msrv }} diff --git a/Cargo.toml b/Cargo.toml index bacfcdf65..513973489 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -10,7 +10,7 @@ repository = "https://github.com/lancedb/lancedb" description = "Serverless, low-latency vector database for AI applications" keywords = ["lancedb", "lance", "database", "vector", "search"] categories = ["database-implementations"] -rust-version = "1.91.0" +rust-version = "1.94.0" [workspace.dependencies] lance = { "version" = "=14.0.0-beta.1", default-features = false, "tag" = "v14.0.0-beta.1", "git" = "https://github.com/lance-format/lance.git" } diff --git a/python/Cargo.toml b/python/Cargo.toml index 9ba96b55f..d032359d0 100644 --- a/python/Cargo.toml +++ b/python/Cargo.toml @@ -8,7 +8,7 @@ license.workspace = true repository.workspace = true keywords.workspace = true categories.workspace = true -rust-version = "1.91.0" +rust-version = "1.94.0" [lib] name = "_lancedb"