mirror of
https://github.com/lancedb/lancedb.git
synced 2026-10-30 15:26:52 +00:00
feat: add a cascade option to drop_database (#4697)
The remote catalog could only drop an empty database: it always asked
the server for a restricted drop.
`DropDatabaseRequest::cascade`, `drop_database(..., cascade=True)` in
Python and `dropDatabase(name, { cascade: true })` in TypeScript ask the
server to drop everything in the database first. The name stays taken
until the server finishes cleaning up the dropped objects' storage. A
restricted drop remains the default.
This commit is contained in:
@@ -124,10 +124,17 @@ impl Catalog {
|
||||
.default_error()
|
||||
}
|
||||
#[napi]
|
||||
pub async fn drop_database(&self, name: String, ignore_missing: Option<bool>) -> Result<()> {
|
||||
pub async fn drop_database(
|
||||
&self,
|
||||
name: String,
|
||||
ignore_missing: Option<bool>,
|
||||
cascade: Option<bool>,
|
||||
) -> Result<()> {
|
||||
self.inner
|
||||
.drop_database(
|
||||
DropDatabaseRequest::new(name).ignore_missing(ignore_missing.unwrap_or(false)),
|
||||
DropDatabaseRequest::new(name)
|
||||
.ignore_missing(ignore_missing.unwrap_or(false))
|
||||
.cascade(cascade.unwrap_or(false)),
|
||||
)
|
||||
.await
|
||||
.default_error()
|
||||
|
||||
Reference in New Issue
Block a user