diff --git a/nodejs/src/table.rs b/nodejs/src/table.rs index 241d469f..1817abf6 100644 --- a/nodejs/src/table.rs +++ b/nodejs/src/table.rs @@ -124,7 +124,7 @@ impl Table { #[napi(catch_unwind)] pub async fn delete(&self, predicate: String) -> napi::Result<()> { - self.inner_ref()?.delete(&predicate, None).await.map_err(|e| { + self.inner_ref()?.delete(&predicate).await.map_err(|e| { napi::Error::from_reason(format!( "Failed to delete rows in table {}: predicate={}", self.name, e diff --git a/python/src/table.rs b/python/src/table.rs index dba262ca..1e12d4c0 100644 --- a/python/src/table.rs +++ b/python/src/table.rs @@ -119,7 +119,7 @@ impl Table { pub fn delete(self_: PyRef<'_, Self>, condition: String) -> PyResult<&PyAny> { let inner = self_.inner_ref()?.clone(); future_into_py(self_.py(), async move { - inner.delete(&condition, None).await.infer_error() + inner.delete(&condition).await.infer_error() }) } diff --git a/rust/ffi/node/src/table.rs b/rust/ffi/node/src/table.rs index 5bd00c1c..b47af535 100644 --- a/rust/ffi/node/src/table.rs +++ b/rust/ffi/node/src/table.rs @@ -168,7 +168,7 @@ impl JsTable { let table = js_table.table.clone(); rt.spawn(async move { - let delete_result = table.delete(&predicate, None).await; + let delete_result = table.delete(&predicate).await; deferred.settle_with(&channel, move |mut cx| { delete_result.or_throw(&mut cx)?; diff --git a/rust/lancedb/examples/simple.rs b/rust/lancedb/examples/simple.rs index 725cc65b..775dd560 100644 --- a/rust/lancedb/examples/simple.rs +++ b/rust/lancedb/examples/simple.rs @@ -50,7 +50,7 @@ async fn main() -> Result<()> { create_empty_table(&db).await.unwrap(); // --8<-- [start:delete] - tbl.delete("id > 24", None).await.unwrap(); + tbl.delete("id > 24").await.unwrap(); // --8<-- [end:delete] // --8<-- [start:drop_table] diff --git a/rust/lancedb/src/table.rs b/rust/lancedb/src/table.rs index 38b1ed5b..599a6369 100644 --- a/rust/lancedb/src/table.rs +++ b/rust/lancedb/src/table.rs @@ -391,7 +391,7 @@ pub(crate) trait TableInternal: std::fmt::Display + std::fmt::Debug + Send + Syn add: AddDataBuilder, data: Box, ) -> Result<()>; - async fn delete(&self, predicate: &str, write_options: Option) -> Result<()>; + async fn delete(&self, predicate: &str) -> Result<()>; async fn update(&self, update: UpdateBuilder) -> Result<()>; async fn create_index(&self, index: IndexBuilder) -> Result<()>; async fn list_indices(&self) -> Result>; @@ -558,8 +558,8 @@ impl Table { /// tbl.delete("id > 5").await.unwrap(); /// # }); /// ``` - pub async fn delete(&self, predicate: &str, write_options: Option) -> Result<()> { - self.inner.delete(predicate, write_options).await + pub async fn delete(&self, predicate: &str) -> Result<()> { + self.inner.delete(predicate).await } /// Create an index on the provided column(s). @@ -1853,9 +1853,8 @@ impl TableInternal for NativeTable { } /// Delete rows from the table - async fn delete(&self, predicate: &str, write_options: Option) -> Result<()> { - let write_params = write_options.and_then(|e| e.lance_write_params); - self.dataset.get_mut().await?.delete(predicate, write_params).await?; + async fn delete(&self, predicate: &str) -> Result<()> { + self.dataset.get_mut().await?.delete(predicate).await?; Ok(()) }