rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-05-14 10:30:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix!: sort table names (#619)

Browse Source 
https://github.com/lancedb/lance/issues/1385
This commit is contained in:
Bert
2023-11-01 10:50:09 -04:00
committed by Weston Pace
parent 3c139c2ee5
commit cd7a4dd251
3 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
python/lancedb/db.py
View File

@@ -263,7 +263,7 @@ class LanceDBConnection(DBConnection):
return self._uri
def table_names(self) -> list[str]:
"""Get the names of all tables in the database.
"""Get the names of all tables in the database. The names are sorted.
Returns
-------
@@ -287,6 +287,7 @@ class LanceDBConnection(DBConnection):
for file_info in paths
if file_info.extension == "lance"
]
tables.sort()
return tables
def __len__(self) -> int:

15
python/tests/test_db.py
View File

@@ -150,6 +150,21 @@ def test_ingest_iterator(tmp_path):
run_tests(PydanticSchema)
def test_table_names(tmp_path):
db = lancedb.connect(tmp_path)
data = pd.DataFrame(
{
"vector": [[3.1, 4.1], [5.9, 26.5]],
"item": ["foo", "bar"],
"price": [10.0, 20.0],
}
)
db.create_table("test2", data=data)
db.create_table("test1", data=data)
db.create_table("test3", data=data)
assert db.table_names() == ["test1", "test2", "test3"]
def test_create_mode(tmp_path):
db = lancedb.connect(tmp_path)
data = pd.DataFrame(