rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-01-07 04:12:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: lint and enforce linting (#829)

Browse Source 
@eddyxu added instructions for linting here:


7af213801a/python/README.md (L45-L50)

However, we had a lot of failures and weren't checking this in CI. This
PR fixes all lints and adds a check to CI to keep us in compliance with
the lints.
This commit is contained in:
Will Jones
2024-01-19 13:09:14 -08:00
committed by GitHub
parent 7af213801a
commit d012db24c2
28 changed files with 250 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
python/tests/test_cli.py
View File

@@ -15,11 +15,11 @@ def test_diagnostics():
runner = CliRunner()
result = runner.invoke(cli, ["diagnostics", "--disabled"])
assert result.exit_code == 0 # Main check
assert CONFIG["diagnostics"] == False
assert not CONFIG["diagnostics"]
result = runner.invoke(cli, ["diagnostics", "--enabled"])
assert result.exit_code == 0 # Main check
assert CONFIG["diagnostics"] == True
assert CONFIG["diagnostics"]
def test_config():
@@ -28,8 +28,5 @@ def test_config():
assert result.exit_code == 0 # Main check
cfg = CONFIG.copy()
cfg.pop("uuid")
for (
item,
_,
) in cfg.items(): # check for keys only as formatting is subject to change
for item in cfg: # check for keys only as formatting is subject to change
assert item in result.output