From d4f5c718adbacf95f488647c7c8f9aec5a3f6746 Mon Sep 17 00:00:00 2001 From: Jack Ye Date: Fri, 2 Oct 2026 10:17:34 -0500 Subject: [PATCH] fix: update remote test helpers for SQL client --- rust/lancedb/src/remote/db.rs | 2 +- rust/lancedb/src/remote/table.rs | 3 +++ rust/lancedb/tests/duplicate_pairs.rs | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/rust/lancedb/src/remote/db.rs b/rust/lancedb/src/remote/db.rs index 15df6bda7..42e4c3206 100644 --- a/rust/lancedb/src/remote/db.rs +++ b/rust/lancedb/src/remote/db.rs @@ -1952,7 +1952,7 @@ mod tests { #[tokio::test] async fn test_create_materialized_view_requires_sql_client() { - let db = super::RemoteDatabase::new_mock(|request| { + let db = super::RemoteDatabase::new_mock(|request| -> http::Response { panic!("unexpected REST request: {}", request.url().path()) }); let error = db diff --git a/rust/lancedb/src/remote/table.rs b/rust/lancedb/src/remote/table.rs index b4fd88bf1..7192f8f9b 100644 --- a/rust/lancedb/src/remote/table.rs +++ b/rust/lancedb/src/remote/table.rs @@ -1622,6 +1622,7 @@ mod test_utils { namespace: vec![], identifier: name, server_version: version.map(ServerVersion).unwrap_or_default(), + sql_client: None, version: Arc::new(RwLock::new(None)), location: RwLock::new(None), schema_cache: BackgroundCache::new(SCHEMA_CACHE_TTL, SCHEMA_CACHE_REFRESH_WINDOW), @@ -1647,6 +1648,7 @@ mod test_utils { namespace: vec![], identifier: name, server_version: ServerVersion::default(), + sql_client: None, version: Arc::new(RwLock::new(None)), location: RwLock::new(None), schema_cache: BackgroundCache::new(SCHEMA_CACHE_TTL, SCHEMA_CACHE_REFRESH_WINDOW), @@ -1681,6 +1683,7 @@ mod test_utils { namespace: vec![], identifier: name, server_version: version.map(ServerVersion).unwrap_or_default(), + sql_client: None, version: Arc::new(RwLock::new(None)), location: RwLock::new(None), schema_cache: BackgroundCache::new(SCHEMA_CACHE_TTL, SCHEMA_CACHE_REFRESH_WINDOW), diff --git a/rust/lancedb/tests/duplicate_pairs.rs b/rust/lancedb/tests/duplicate_pairs.rs index 0ead13057..63f1c9f5a 100644 --- a/rust/lancedb/tests/duplicate_pairs.rs +++ b/rust/lancedb/tests/duplicate_pairs.rs @@ -459,7 +459,6 @@ async fn dedup_query_materializes_blob_payloads_and_null_vectors() -> anyhow::Re true, ) .await?; - let version = ds.version().version; use lancedb::table::datafusion::udtf::{ duplicate_pairs::DuplicatePairsOutput, vector_query::{PartitionSelection, VectorQueryOptions, VectorQueryTable},