From edb79d38e3c486217d30020609428ed759dddd54 Mon Sep 17 00:00:00 2001 From: Joshua Snider Date: Wed, 28 Oct 2026 15:05:40 -0400 Subject: [PATCH] docs: correct the documented default retry statuses (#3964) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #2349 changed the default retryable status codes to `[409, 429, 500, 502, 503, 504]`, but only the Rust docstring was updated. The Python and TypeScript bindings — and the generated TypeScript API reference — still document the old `[429, 500, 502, 503]`. The actual default is set in `ResolvedRetryConfig::try_from` in `rust/lancedb/src/remote/retry.rs`, and `rust/lancedb/src/remote/client.rs` already documents it correctly. This brings the other three in line. Docs only — no behavior change. Split out from #3963 per the "one problem at a time" guidance in `CONTRIBUTING.md`. --- docs/src/js/interfaces/RetryConfig.md | 2 +- nodejs/src/remote.rs | 2 +- python/python/lancedb/remote/__init__.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/src/js/interfaces/RetryConfig.md b/docs/src/js/interfaces/RetryConfig.md index a9e4e6046..4f9336b66 100644 --- a/docs/src/js/interfaces/RetryConfig.md +++ b/docs/src/js/interfaces/RetryConfig.md @@ -84,7 +84,7 @@ optional statuses: number[]; ``` The HTTP status codes for which to retry the request. Default is -[429, 500, 502, 503]. +[409, 429, 500, 502, 503, 504]. You can also set this via the environment variable `LANCE_CLIENT_RETRY_STATUSES`. Use a comma-separated list of integers. diff --git a/nodejs/src/remote.rs b/nodejs/src/remote.rs index c776ea597..2a6985477 100644 --- a/nodejs/src/remote.rs +++ b/nodejs/src/remote.rs @@ -69,7 +69,7 @@ pub struct RetryConfig { /// `LANCE_CLIENT_RETRY_BACKOFF_JITTER`. pub backoff_jitter: Option, /// The HTTP status codes for which to retry the request. Default is - /// [429, 500, 502, 503]. + /// [409, 429, 500, 502, 503, 504]. /// /// You can also set this via the environment variable /// `LANCE_CLIENT_RETRY_STATUSES`. Use a comma-separated list of integers. diff --git a/python/python/lancedb/remote/__init__.py b/python/python/lancedb/remote/__init__.py index bb9a32122..15015a8e0 100644 --- a/python/python/lancedb/remote/__init__.py +++ b/python/python/lancedb/remote/__init__.py @@ -124,7 +124,7 @@ class RetryConfig: `LANCE_CLIENT_RETRY_BACKOFF_JITTER`. statuses: Optional[List[int] The HTTP status codes for which to retry the request. Default is - [429, 500, 502, 503]. + [409, 429, 500, 502, 503, 504]. You can also set this via the environment variable `LANCE_CLIENT_RETRY_STATUSES`. Use a comma-separated list of integers.