From edd9a043f8362fc3a8c3eea9c2e35b9580e50f64 Mon Sep 17 00:00:00 2001 From: BubbleCal Date: Thu, 29 Feb 2024 15:00:24 +0800 Subject: [PATCH] chore: enable test for dropping table (#1038) Signed-off-by: BubbleCal --- rust/lancedb/src/connection.rs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/rust/lancedb/src/connection.rs b/rust/lancedb/src/connection.rs index 813f6f71..5b871b8b 100644 --- a/rust/lancedb/src/connection.rs +++ b/rust/lancedb/src/connection.rs @@ -707,8 +707,6 @@ mod tests { let db = connect(uri).execute().await.unwrap(); assert_eq!(db.table_names().await.unwrap().len(), 0); - - db.open_table("invalid_table").execute().await.unwrap(); // open non-exist table assert!(matches!( db.open_table("invalid_table").execute().await, @@ -735,11 +733,10 @@ mod tests { let db = connect(uri).execute().await.unwrap(); // drop non-exist table - // TODO(BubbleCal): enable this after upgrading lance with https://github.com/lancedb/lance/pull/1995 merged - // assert!(matches!( - // db.drop_table("invalid_table").await, - // Err(crate::Error::TableNotFound { .. }), - // )); + assert!(matches!( + db.drop_table("invalid_table").await, + Err(crate::Error::TableNotFound { .. }), + )); create_dir_all(tmp_dir.path().join("table1.lance")).unwrap(); db.drop_table("table1").await.unwrap();