From f45f0d0431b898c298789d5b2ec85e4275e7f443 Mon Sep 17 00:00:00 2001 From: aniaan Date: Fri, 25 Jul 2025 03:31:49 +0800 Subject: [PATCH] fix(python): correct type annotations in EmbeddingFunctionRegistry (#2478) - Fix register() method's alias parameter type from 'str = None' to 'Optional[str] = None' - Add return type annotation 'Type[EmbeddingFunction]' to get() method - Import Type from typing module for proper type hints --- python/python/lancedb/embeddings/registry.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/python/python/lancedb/embeddings/registry.py b/python/python/lancedb/embeddings/registry.py index 91424253..10978486 100644 --- a/python/python/lancedb/embeddings/registry.py +++ b/python/python/lancedb/embeddings/registry.py @@ -2,7 +2,7 @@ # SPDX-FileCopyrightText: Copyright The LanceDB Authors import json -from typing import Dict, Optional +from typing import Dict, Optional, Type from .base import EmbeddingFunction, EmbeddingFunctionConfig @@ -43,7 +43,7 @@ class EmbeddingFunctionRegistry: self._functions = {} self._variables = {} - def register(self, alias: str = None): + def register(self, alias: Optional[str] = None): """ This creates a decorator that can be used to register an EmbeddingFunction. @@ -75,7 +75,7 @@ class EmbeddingFunctionRegistry: """ self._functions = {} - def get(self, name: str): + def get(self, name: str) -> Type[EmbeddingFunction]: """ Fetch an embedding function class by name