From fa342e7df493a3984403252cd4c05d98a40fe93f Mon Sep 17 00:00:00 2001 From: qzhu Date: Thu, 14 Mar 2024 15:56:50 -0700 Subject: [PATCH] init debug --- python/python/lancedb/query.py | 7 ++++--- python/python/lancedb/table.py | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/python/python/lancedb/query.py b/python/python/lancedb/query.py index 2c2ef71b..ef1fd4c3 100644 --- a/python/python/lancedb/query.py +++ b/python/python/lancedb/query.py @@ -271,7 +271,8 @@ class LanceQueryBuilder(ABC): and also the "_distance" column which is the distance between the query vector and the returned vectors. """ - raise NotImplementedError + # raise NotImplementedError + self.to_arrow() def to_list(self) -> List[dict]: """ @@ -434,12 +435,12 @@ class LanceVectorQueryBuilder(LanceQueryBuilder): self._vector_column = vector_column self._prefilter = False - def metric(self, metric: Literal["L2", "cosine"]) -> LanceVectorQueryBuilder: + def metric(self, metric: Literal["L2", "cosine", "dot"]) -> LanceVectorQueryBuilder: """Set the distance metric to use. Parameters ---------- - metric: "L2" or "cosine" + metric: "L2" or "cosine" or "dot" The distance metric to use. By default "L2" is used. Returns diff --git a/python/python/lancedb/table.py b/python/python/lancedb/table.py index e050749b..fbd30493 100644 --- a/python/python/lancedb/table.py +++ b/python/python/lancedb/table.py @@ -1522,7 +1522,7 @@ class LanceTable(Table): def _execute_query(self, query: Query) -> pa.Table: ds = self.to_lance() - + print("metric:", query.metric) return ds.to_table( columns=query.columns, filter=query.filter,