Will Jones
2bfdef2624
ci: refactor node releases ( #2223 )
...
This PR fixes build issues associated with `aws-lc-rs`, while
simplifying the build process. Previously, we used custom scripts for
the musl and Windows ARM builds. These were complicated and prone to
breaking. This PR switches to a setup that mirrors
https://github.com/napi-rs/package-template/blob/main/.github/workflows/CI.yml .
* linux glibc and musl builds now use the Docker images provided by the
napi project
* Windows ARM build now just cross compiles from Windows x64, which
turns out to work quite well.
2025-03-21 10:56:29 -07:00
Matt Basta
6008a8257b
fix: remove native.d.ts from .npmignore ( #1531 )
...
This removes the type definitions for a number of important TypeScript
interfaces from `.npmignore` so that the package is not incorrectly
typed `any` in a number of places.
---
Presently the `opts` argument to `lancedb.connect` is typed `any`, even
though it shouldn't be.
<img width="560" alt="image"
src="https://github.com/user-attachments/assets/5c974ce8-5a59-44a1-935d-cbb808f0ea24 ">
Clicking into the type definitions for the published package, it has the
correct type signature:
<img width="831" alt="image"
src="https://github.com/user-attachments/assets/6e39a519-13ff-4ca8-95ae-85538ac59d5d ">
However, `ConnectionOptions` is imported from `native.js` (along with a
number of other imports a bit further down):
<img width="384" alt="image"
src="https://github.com/user-attachments/assets/10c1b055-ae78-4088-922e-2816af64c23c ">
This is not otherwise an issue, except that the type definitions for
`native.js` are not included in the published package:
<img width="217" alt="image"
src="https://github.com/user-attachments/assets/f15cd3b6-a8de-4011-9fa2-391858da20ec ">
I haven't compiled the Rust code and run the build script, but I
strongly suspect that disincluding the type definitions in `.npmignore`
is ultimately the root cause here.
2024-08-13 10:06:15 -07:00
Gagan Bhullar
30047a5566
fix: remove source .ts code from published npm package ( #1467 )
...
This PR is for issue - https://github.com/lancedb/lancedb/issues/1358
2024-07-23 13:11:54 -07:00
Lei Xu
efcaa433fe
feat: rework NodeJS SDK using napi ( #847 )
...
Use Napi to write a Node.js SDK that follows Polars for better
maintainability, while keeping most of the logic in Rust.
2024-04-05 16:27:51 -07:00
