give up on musl for now

.github/workflows/release.yml

@@ -39,6 +39,7 @@ jobs:
         with:
           draft: true
           files: target/vectordb-*.crate
+          fail_on_unmatched_files: true
     
   python:
     runs-on: ubuntu-latest
@@ -66,6 +67,7 @@ jobs:
           files: |
             python/dist/lancedb-*.tar.gz 
             python/dist/lancedb-*.whl
+          fail_on_unmatched_files: true
 
   node:
     runs-on: ubuntu-latest
@@ -95,6 +97,7 @@ jobs:
         with:
           draft: true
           files: node/vectordb-*.tgz
+          fail_on_unmatched_files: true
 
   node-macos:
     runs-on: macos-12
@@ -118,6 +121,7 @@ jobs:
       with:
         draft: true
         files: node/dist/vectordb-darwin*.tgz
+        fail_on_unmatched_files: true
 
   node-linux:
     name: node-linux (${{ matrix.arch}}-unknown-linux-${{ matrix.libc }})
@@ -128,13 +132,20 @@ jobs:
       matrix:
         libc:
           - gnu
-          - musl
+          # TODO: re-enable musl once we have refactored to pre-built containers
+          # Right now we have to build node from source which is too expensive.
+          # - musl
         arch:
           - x86_64
           - aarch64
     steps:
     - name: Checkout
       uses: actions/checkout@v2
+    - name: Set up QEMU
+      if: ${{ matrix.arch == 'aarch64' }}
+      uses: docker/setup-qemu-action@v2  
+      with:
+        platforms: arm64
     - name: Build Linux GNU native node modules
       if: ${{ matrix.libc == 'gnu' }}
       run: |
@@ -145,7 +156,7 @@ jobs:
     - name: Build musl Linux native node modules
       if: ${{ matrix.libc == 'musl' }}
       run: |
-        docker run \
+        docker run --platform linux/arm64/v8 \
           -v $(pwd):/io -w /io \
           quay.io/pypa/musllinux_1_1_${{ matrix.arch }} \
           bash ci/build_linux_artifacts.sh ${{ matrix.arch }}-unknown-linux-musl
@@ -153,6 +164,7 @@ jobs:
       with:
         draft: true
         files: node/dist/vectordb-linux*.tgz
+        fail_on_unmatched_files: true
 
   release:
     needs: [python, node, node-macos, node-linux, rust]

ci/build_linux_artifacts.sh

@@ -7,10 +7,7 @@
 # - aarch64-unknown-linux-musl
 # - x86_64-unknown-linux-musl
 
-# On MacOS, need to run in a linux container:
+# TODO: refactor this into a Docker container we can pull
-# docker run -v $(pwd):/io -w /io 
-
-# Must run rustup toolchain install stable-x86_64-unknown-linux-gnu --force-non-host
 
 set -e
 
@@ -40,11 +37,15 @@ setup_dependencies() {
 
 install_node() {
     echo "Installing node..."
+    curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash
+    source "$HOME"/.bashrc
+
     if [[ $1 == *musl ]]; then
-        apk add nodejs-current npm
+        # This node version is 15, we need 16 or higher:
+        # apk add nodejs-current npm 
+        # So instead we install from source (nvm doesn't provide binaries for musl):
+        nvm install -s 17
     else
-        curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash
-        source "$HOME"/.nvm/nvm.sh
         nvm install 17 # latest that supports glibc 2.17
     fi
 }
@@ -53,7 +54,6 @@ install_rust() {
     echo "Installing rust..."
     curl https://sh.rustup.rs -sSf | bash -s -- -y
     export PATH="$PATH:/root/.cargo/bin"
-    rustup target add $1
 }
 
 build_node_binary() {
@@ -64,8 +64,10 @@ build_node_binary() {
         # This is needed for cargo to allow build cdylibs with musl
         export RUSTFLAGS="-C target-feature=-crt-static"
     fi
-    npm run build-release -- --target $1
+    # We don't pass in target, since the native target here already matches
-    npm run pack-build -- --target $1
+    # and openblas-src doesn't do well with cross-compilation.
+    npm run build-release
+    npm run pack-build
 
     popd
 }
@@ -77,6 +79,6 @@ TARGET=${1:-x86_64-unknown-linux-gnu}
 # aarch64-unknown-linux-musl
 
 setup_dependencies $TARGET
-install_node
+install_node $TARGET
-install_rust $TARGET
+install_rust
 build_node_binary $TARGET

ci/release_process.md

@@ -102,3 +102,10 @@ docker run -it \
     bash
 ```
 -->
+
+```
+docker run \
+    -v $(pwd):/io -w /io \
+    quay.io/pypa/musllinux_1_1_aarch64 \
+    bash alpine_repro.sh
+```

ci/ubuntu_build.dockerfile

@@ -1,31 +0,0 @@
-# On MacOS, need to run in a linux container:
-# cat ci/ubuntu_build.dockerfile | docker build -t lancedb-node-build -
-# docker run -v /var/run/docker.sock:/var/run/docker.sock -v $(pwd):/io -w /io lancedb-node-build bash ci/build_linux_artifacts.sh
-FROM ubuntu:20.04
-
-ARG DEBIAN_FRONTEND=noninteractive
-ENV TZ=Europe/Moscow
-
-RUN apt update && apt install -y protobuf-compiler libssl-dev build-essential curl \
-    software-properties-common npm docker.io
-
-# Install rust
-RUN curl https://sh.rustup.rs -sSf | bash -s -- -y
-
-ENV PATH="/root/.cargo/bin:${PATH}"
-
-# Install cross
-# https://github.com/cross-rs/cross/issues/1257#issuecomment-1544553706
-RUN cargo install cross --git https://github.com/cross-rs/cross
-
-# Install additional build targets
-RUN rustup target add x86_64-unknown-linux-gnu aarch64-unknown-linux-gnu aarch64-unknown-linux-musl x86_64-unknown-linux-musl
-
-# Install node
-RUN npm install npm@latest -g && \
-    npm install n -g && \
-    n latest
-
-# set CROSS_CONTAINER_IN_CONTAINER to inform `cross` that it is executed from within a container
-ENV CROSS_CONTAINER_IN_CONTAINER=true
-ENV CROSS_CONTAINER_ENGINE_NO_BUILDKIT=1