mirror of
https://github.com/lancedb/lancedb.git
synced 2026-05-14 18:40:39 +00:00
81617fd3d9
## Summary Switch the nodejs bindings and examples package from npm to pnpm 11 to pick up its stronger supply-chain defaults: - `minimumReleaseAge` defaults to 1 day, so newly-published (potentially compromised) versions aren't resolved into installs for at least 24h. - Install lifecycle scripts (`preinstall`/`install`/`postinstall`) are no longer run for arbitrary transitive deps; only an explicit allowlist may run them, and unapproved scripts cause install to fail (`strictDepBuilds: true`). - Audit uses GHSA IDs and `--fix=update` to add patched versions to `minimumReleaseAgeExclude`. This is the same class of protection that would have blunted the recent TanStack/`@uipath`/etc. compromise discussed in the [Aikido write-up](https://www.aikido.dev/blog/mini-shai-hulud-is-back-tanstack-compromised). ## Changes - Replace `nodejs/package-lock.json` and `nodejs/examples/package-lock.json` with `pnpm-lock.yaml`. - Pin pnpm via `packageManager: pnpm@11.1.1` in both `package.json`s. - Add `pnpm-workspace.yaml` with the four build-script packages we actually need: `@biomejs/biome`, `onnxruntime-node`, `protobufjs`, `sharp`. Everything else is blocked from running install scripts. - Update package.json scripts (`npm run X` → `pnpm X`). - Update workflows: `.github/workflows/nodejs.yml`, `.github/workflows/npm-publish.yml`, and `.github/workflows/codex-fix-ci.yml` — install pnpm via `pnpm/action-setup@v4` and switch `setup-node` caches to `pnpm-lock.yaml`. - Refresh `nodejs/AGENTS.md`, `nodejs/CLAUDE.md`, and `nodejs/CONTRIBUTING.md`. `docs/package-lock.json` is **not** touched — out of scope for this PR. ## Test plan - [ ] `Lint` job (lint Rust/TS + examples lint) passes on CI. - [ ] `Linux (NodeJS 18/20)` build+test passes, including the examples test step. - [ ] `macos` build+test passes. - [ ] `NPM Publish` workflow's PR dry-run completes (build matrix + test matrix + dry `npm publish`). - [ ] No new install-script approvals are required at install time. ## Follow-ups - `update_package_lock_run_nodejs.yml` references a composite action path that doesn't exist (`./.github/workflows/update_package_lock_nodejs`); it was already broken pre-PR. We may want to either delete this workflow or rewrite it for pnpm in a follow-up. - Consider migrating `docs/` to pnpm in a separate PR. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
35 lines
1.1 KiB
JSON
35 lines
1.1 KiB
JSON
{
|
|
"name": "examples",
|
|
"version": "1.0.0",
|
|
"description": "Examples for LanceDB",
|
|
"main": "index.js",
|
|
"type": "module",
|
|
"scripts": {
|
|
"//1": "--experimental-vm-modules is needed to run jest with sentence-transformers",
|
|
"//2": "--testEnvironment is needed to run jest with sentence-transformers",
|
|
"//3": "See: https://github.com/huggingface/transformers.js/issues/57",
|
|
"test": "node --experimental-vm-modules node_modules/.bin/jest --testEnvironment jest-environment-node-single-context --verbose",
|
|
"lint": "biome check *.ts && biome format *.ts",
|
|
"lint-ci": "biome ci .",
|
|
"lint-fix": "biome check --write *.ts && pnpm format",
|
|
"format": "biome format --write *.ts"
|
|
},
|
|
"author": "Lance Devs",
|
|
"license": "Apache-2.0",
|
|
"packageManager": "pnpm@11.1.1",
|
|
"dependencies": {
|
|
"@huggingface/transformers": "3.0.2",
|
|
"@lancedb/lancedb": "file:../dist",
|
|
"openai": "4.29.2",
|
|
"sharp": "0.33.5"
|
|
},
|
|
"devDependencies": {
|
|
"@biomejs/biome": "^1.7.3",
|
|
"@jest/globals": "^29.7.0",
|
|
"jest": "^29.7.0",
|
|
"jest-environment-node-single-context": "^29.4.0",
|
|
"ts-jest": "^29.2.5",
|
|
"typescript": "^5.5.4"
|
|
}
|
|
}
|