mirror of
https://github.com/lancedb/lancedb.git
synced 2026-05-16 19:40:40 +00:00
c3cc2530b7
Fixes #2612 This PR exposes the private _fast_search attribute via a public fast_search() method in the synchronous LanceVectorQueryBuilder. Previously, enabling fast search in the sync API required accessing a private member (query._fast_search = True). This change aligns the synchronous API with the Async and Remote APIs, allowing for cleaner, more Pythonic method chaining. Changes: Added fast_search() method to LanceVectorQueryBuilder in python/python/lancedb/query.py. Added a unit test verifying the flag works with high-dimensional data (2560 dims) and chaining. Example Usage: Before: ``` query = table.search(vector) query._fast_search = True # Private attribute usage results = query.limit(10).to_pandas() ``` After: ``` results = ( table.search(vector) .fast_search() .limit(10) .to_pandas() ) ``` Verification: I have added a test case (test_fast_search_high_dimension) that replicates the scenario described in the issue (2560 dimensions, cosine distance) to ensure the pipeline constructs the query correctly without errors. Checklist: - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] Documentation has been updated (inline docstrings). Signed-off-by: Rashidul Islam <rasidulislam71@gmail.com>