mirror of
https://github.com/lancedb/lancedb.git
synced 2026-10-23 20:22:37 +00:00
lancedb-gatefixer[bot]
624defd109
## Root cause The pinned Lance Arrow crate rebuilt a sliced struct child with its original Arrow offset but supplied a validity bitmap containing only the visible rows. Arrow requires the bitmap to cover the offset as well, so filtered vector searches involving nullable nested fields could panic with `null_bit_buffer size too small`. ## Fix - Carry an offset-aligned validity bitmap when propagating parent nulls to a sliced child. - Vendor the pinned `lance-arrow` crate until a Lance release includes the fix; include it in Maturin source distributions. - Add unit regressions for sliced children and parent bitmaps, plus a record-batch merge regression. ## Validation - The issue's 8,600-row Python reproducer completes its filtered flat dot search and returns 8,448 rows without a panic. - The targeted Rust merge regression and two focused Python query tests pass. - Rust formatting, Ruff formatting and lint, the vendored crate tests, and the workspace Cargo checks passed. The Maturin source archive includes the patched crate. Fixes #4260 <!-- lance-gatekeeper-fix:v1 agent=e6045f701d9b708ee26528ba36353aba generation=1 --> --------- Co-authored-by: Gatefixer <313497061+lancedb-gatefixer[bot]@users.noreply.github.com>
469 B
469 B
This directory contains rust/lance-arrow from Lance tag v15.0.0-beta.1
(commit 46a7cfe1fba5efa1f90deea4c7b14d414b991409), licensed under Apache-2.0.
LanceDB carries a local fix in src/lib.rs for sliced child validity bitmaps
until a Lance release includes the fix. The patch is selected in the root
Cargo.toml; the rest of Lance stays on the pinned release. An explicit unsafe
block in src/bfloat16.rs lets this copy pass LanceDB's Rust 2024 warning gate.