mirror of
https://github.com/lancedb/lancedb.git
synced 2026-10-23 20:22:37 +00:00
lancedb-gatefixer[bot]
ba7b7f15c2
## Summary - inspect the assembled x64 musl addon for the unresolved AVX-512 distance-table symbol before npm publication - fail the publish lifecycle with an actionable error if the broken symbol is present - add regression coverage using the dynamic-symbol output from the affected 0.27.x artifact ## Root cause LanceDB 0.27.x could enable the Rust AVX-512 distance-table callsite when the separate C kernel build did not emit its object, leaving `sum_4bit_dist_table_32bytes_batch_avx512` undefined in the musl addon. The current Lance dependency includes the upstream split-kernel cfg fix, and the published 0.33.0 musl artifact no longer has the undefined symbol, but the LanceDB publish path did not verify that property before releasing an addon. This adds a release guard around the corrected implementation so the same invalid binary cannot be published again. ## Validation - `pnpm lint` - `pnpm run build` - `pnpm test --runInBand` (680 passed, 5 skipped) - `pnpm run docs` - checked published artifacts: 0.27.1 is rejected for the unresolved symbol; 0.33.0 is accepted Fixes #3200 <!-- lance-gatekeeper-fix:v1 agent=4094b9b6de4b43665a9ff50fa35322fb generation=1 --> Co-authored-by: Gatefixer <313497061+lancedb-gatefixer[bot]@users.noreply.github.com>
78 lines
1.9 KiB
JavaScript
78 lines
1.9 KiB
JavaScript
// SPDX-License-Identifier: Apache-2.0
|
|
// SPDX-FileCopyrightText: Copyright The LanceDB Authors
|
|
|
|
const { spawnSync } = require("node:child_process");
|
|
const { existsSync } = require("node:fs");
|
|
const path = require("node:path");
|
|
|
|
const FORBIDDEN_UNDEFINED_SYMBOLS = new Set([
|
|
"sum_4bit_dist_table_32bytes_batch_avx512",
|
|
]);
|
|
|
|
function findForbiddenUndefinedSymbols(output) {
|
|
const found = new Set();
|
|
|
|
for (const line of output.split(/\r?\n/)) {
|
|
const columns = line.trim().split(/\s+/);
|
|
const symbol = columns.at(-1)?.split("@")[0];
|
|
if (symbol && FORBIDDEN_UNDEFINED_SYMBOLS.has(symbol)) {
|
|
found.add(symbol);
|
|
}
|
|
}
|
|
|
|
return [...found].sort();
|
|
}
|
|
|
|
function checkNativeBinary(binaryPath, runNm = spawnSync) {
|
|
const result = runNm("nm", ["-D", "--undefined-only", binaryPath], {
|
|
encoding: "utf8",
|
|
});
|
|
|
|
if (result.error) {
|
|
throw new Error(`Unable to inspect ${binaryPath}: ${result.error.message}`);
|
|
}
|
|
if (result.status !== 0) {
|
|
throw new Error(
|
|
`Unable to inspect ${binaryPath}: nm exited with status ${result.status}\n${result.stderr}`,
|
|
);
|
|
}
|
|
|
|
const forbidden = findForbiddenUndefinedSymbols(result.stdout);
|
|
if (forbidden.length > 0) {
|
|
throw new Error(
|
|
`${binaryPath} contains unresolved internal Lance symbols: ${forbidden.join(
|
|
", ",
|
|
)}`,
|
|
);
|
|
}
|
|
}
|
|
|
|
function main() {
|
|
const binaryPath = path.resolve(
|
|
__dirname,
|
|
"..",
|
|
"npm",
|
|
"linux-x64-musl",
|
|
"lancedb.linux-x64-musl.node",
|
|
);
|
|
|
|
if (!existsSync(binaryPath)) {
|
|
throw new Error(
|
|
`Missing ${binaryPath}; assemble the native artifacts before publishing`,
|
|
);
|
|
}
|
|
|
|
checkNativeBinary(binaryPath);
|
|
}
|
|
|
|
if (require.main === module) {
|
|
try {
|
|
main();
|
|
} catch (error) {
|
|
console.error(error instanceof Error ? error.message : error);
|
|
process.exitCode = 1;
|
|
}
|
|
}
|
|
|
|
module.exports = { checkNativeBinary, findForbiddenUndefinedSymbols };
|