mirror of
https://github.com/lancedb/lancedb.git
synced 2026-11-13 14:16:54 +00:00
lancedb-gatefixer[bot]
7466dc9d1d
Fixes #4761 `Table.update` does not compute embeddings, so changing an embedding source column could leave the previous embedding in place. Source-column updates now raise `ValueError` unless every associated vector column is supplied in the same call. The guard reads Python embedding metadata and native `lancedb::column_definitions` without loading embedding models. It uses Lance's field-path parser for quoted targets and covers synchronous and asynchronous local and remote tables. Supplying every associated vector column, vector-only updates, and unrelated updates remain supported. This is a breaking change for source-only updates. The API documentation and Update rows guide explain the requirement and the `merge_insert` alternative for regenerating embeddings. Validation at the reviewed head covered 44 targeted public update cases and the full Python suite (3107 passed, 162 skipped, 70 deselected). All applicable exact-head checks and workflows completed successfully.
73 lines
2.4 KiB
Rust
73 lines
2.4 KiB
Rust
// SPDX-License-Identifier: Apache-2.0
|
|
// SPDX-FileCopyrightText: Copyright The LanceDB Authors
|
|
|
|
use std::sync::Mutex;
|
|
|
|
use lancedb::DistanceType;
|
|
use pyo3::{
|
|
PyResult,
|
|
exceptions::{PyRuntimeError, PyValueError},
|
|
pyfunction,
|
|
};
|
|
|
|
/// A wrapper around a rust builder
|
|
///
|
|
/// Rust builders are often implemented so that the builder methods
|
|
/// consume the builder and return a new one. This is not compatible
|
|
/// with the pyo3, which, being garbage collected, cannot easily obtain
|
|
/// ownership of an object.
|
|
///
|
|
/// This wrapper converts the compile-time safety of rust into runtime
|
|
/// errors if any attempt to use the builder happens after it is consumed.
|
|
pub struct BuilderWrapper<T> {
|
|
name: String,
|
|
inner: Mutex<Option<T>>,
|
|
}
|
|
|
|
impl<T> BuilderWrapper<T> {
|
|
pub fn new(name: impl AsRef<str>, inner: T) -> Self {
|
|
Self {
|
|
name: name.as_ref().to_string(),
|
|
inner: Mutex::new(Some(inner)),
|
|
}
|
|
}
|
|
|
|
pub fn consume<O>(&self, mod_fn: impl FnOnce(T) -> O) -> PyResult<O> {
|
|
let mut inner = self.inner.lock().unwrap();
|
|
let inner_builder = inner.take().ok_or_else(|| {
|
|
PyRuntimeError::new_err(format!("{} has already been consumed", self.name))
|
|
})?;
|
|
let result = mod_fn(inner_builder);
|
|
Ok(result)
|
|
}
|
|
}
|
|
|
|
pub fn parse_distance_type(distance_type: impl AsRef<str>) -> PyResult<DistanceType> {
|
|
match distance_type.as_ref().to_lowercase().as_str() {
|
|
"l2" => Ok(DistanceType::L2),
|
|
"cosine" => Ok(DistanceType::Cosine),
|
|
"dot" => Ok(DistanceType::Dot),
|
|
"hamming" => Ok(DistanceType::Hamming),
|
|
_ => Err(PyValueError::new_err(format!(
|
|
"Invalid distance type '{}'. Must be one of l2, cosine, dot, or hamming",
|
|
distance_type.as_ref()
|
|
))),
|
|
}
|
|
}
|
|
|
|
#[pyfunction]
|
|
pub fn validate_table_name(table_name: &str) -> PyResult<()> {
|
|
lancedb::utils::validate_table_name(table_name)
|
|
.map_err(|e| PyValueError::new_err(e.to_string()))
|
|
}
|
|
|
|
/// Parse field references with the same identifier syntax as Lance writes.
|
|
#[pyfunction(name = "_parse_field_path")]
|
|
pub fn parse_field_path(path: &str) -> PyResult<Vec<String>> {
|
|
lance_core::datatypes::parse_field_path(path).map_err(|e| PyValueError::new_err(e.to_string()))
|
|
}
|
|
|
|
/// A wrapper around a LanceDB type to allow it to be used in Python
|
|
#[derive(Debug, Clone)]
|
|
pub struct PyLanceDB<T>(pub T);
|