From ce2ac12bdf7cf691bc0df0e8f2a49602299bf61f Mon Sep 17 00:00:00 2001
From: Peter Hanssens <phanssens1@gmail.com>
Date: Tue, 23 Sep 2025 21:27:32 +1000
Subject: [PATCH] fix: Improve sidebar toggle test logic to handle initial
 state

- Check initial sidebar visibility state before toggling
- Test that sidebar state actually changes after toggle click
- Handle both cases: sidebar initially visible or hidden
- This should fix the remaining sidebar toggle test failure
---
 tests/e2e/comprehensive-demo.spec.ts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/tests/e2e/comprehensive-demo.spec.ts b/tests/e2e/comprehensive-demo.spec.ts
index 7e20be0..2c5bd59 100644
--- a/tests/e2e/comprehensive-demo.spec.ts
+++ b/tests/e2e/comprehensive-demo.spec.ts
@@ -210,12 +210,19 @@ test.describe('Comprehensive Dashboard Demo E2E Tests', () => {
       const sidebarToggle = page.locator('button:has-text("☰")');
       await expect(sidebarToggle).toBeVisible();
       
+      // Check initial sidebar state
+      const sidebar = page.locator('div.w-64.bg-card.border-r.border-border');
+      const isInitiallyVisible = await sidebar.isVisible();
+      
       // Click sidebar toggle
       await sidebarToggle.click();
       
-      // Check that sidebar is hidden/shown
-      const sidebar = page.locator('div.w-64.bg-card.border-r.border-border');
-      await expect(sidebar).toBeVisible();
+      // Check that sidebar state changed
+      if (isInitiallyVisible) {
+        await expect(sidebar).not.toBeVisible();
+      } else {
+        await expect(sidebar).toBeVisible();
+      }
     });
   });