From 55c261820190417b3c22d490751c6718c8bb11b2 Mon Sep 17 00:00:00 2001 From: Paolo Barbolini Date: Mon, 2 Aug 2021 11:26:34 +0200 Subject: [PATCH] Fix latest clippy warnings (#655) --- src/message/body.rs | 6 +++--- src/message/header/mod.rs | 4 ++-- src/message/mailbox/types.rs | 2 +- src/message/mod.rs | 2 +- src/transport/mod.rs | 2 +- src/transport/sendmail/mod.rs | 4 ++-- src/transport/smtp/async_transport.rs | 2 +- src/transport/smtp/client/net.rs | 2 +- src/transport/smtp/transport.rs | 2 +- 9 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/message/body.rs b/src/message/body.rs index b973b47..b716125 100644 --- a/src/message/body.rs +++ b/src/message/body.rs @@ -183,8 +183,8 @@ impl MaybeString { /// would result into an invalid encoded body. fn is_encoding_ok(&self, encoding: ContentTransferEncoding) -> bool { match encoding { - ContentTransferEncoding::SevenBit => is_7bit_encoded(&self), - ContentTransferEncoding::EightBit => is_8bit_encoded(&self), + ContentTransferEncoding::SevenBit => is_7bit_encoded(self), + ContentTransferEncoding::EightBit => is_8bit_encoded(self), ContentTransferEncoding::Binary | ContentTransferEncoding::QuotedPrintable | ContentTransferEncoding::Base64 => true, @@ -342,7 +342,7 @@ where /// In place conversion to CRLF line endings fn in_place_crlf_line_endings(string: &mut String) { - let indices = find_all_lf_char_indices(&string); + let indices = find_all_lf_char_indices(string); for i in indices { // this relies on `indices` being in reverse order diff --git a/src/message/header/mod.rs b/src/message/header/mod.rs index 687cdf7..54e372a 100644 --- a/src/message/header/mod.rs +++ b/src/message/header/mod.rs @@ -163,7 +163,7 @@ impl Display for Headers { for (name, value) in &self.headers { Display::fmt(name, f)?; f.write_str(": ")?; - HeaderValueEncoder::encode(&name, &value, f)?; + HeaderValueEncoder::encode(name, value, f)?; f.write_str("\r\n")?; } @@ -240,7 +240,7 @@ impl HeaderName { impl Display for HeaderName { fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { - f.write_str(&self) + f.write_str(self) } } diff --git a/src/message/mailbox/types.rs b/src/message/mailbox/types.rs index a08d610..444f54f 100644 --- a/src/message/mailbox/types.rs +++ b/src/message/mailbox/types.rs @@ -70,7 +70,7 @@ impl Display for Mailbox { if let Some(ref name) = self.name { let name = name.trim(); if !name.is_empty() { - f.write_str(&name)?; + f.write_str(name)?; f.write_str(" <")?; self.email.fmt(f)?; return f.write_char('>'); diff --git a/src/message/mod.rs b/src/message/mod.rs index 1f3d0ce..a8149f4 100644 --- a/src/message/mod.rs +++ b/src/message/mod.rs @@ -523,7 +523,7 @@ impl EmailFormat for Message { MessageBody::Mime(p) => p.format(out), MessageBody::Raw(r) => { out.extend_from_slice(b"\r\n"); - out.extend_from_slice(&r) + out.extend_from_slice(r) } } } diff --git a/src/transport/mod.rs b/src/transport/mod.rs index ac2408f..cb27a4d 100644 --- a/src/transport/mod.rs +++ b/src/transport/mod.rs @@ -152,7 +152,7 @@ pub trait AsyncTransport { async fn send(&self, message: Message) -> Result { let raw = message.formatted(); let envelope = message.envelope(); - self.send_raw(&envelope, &raw).await + self.send_raw(envelope, &raw).await } async fn send_raw(&self, envelope: &Envelope, email: &[u8]) -> Result; diff --git a/src/transport/sendmail/mod.rs b/src/transport/sendmail/mod.rs index e2390b3..d2ce559 100644 --- a/src/transport/sendmail/mod.rs +++ b/src/transport/sendmail/mod.rs @@ -260,7 +260,7 @@ impl AsyncTransport for AsyncSendmailTransport { .stdin .as_mut() .unwrap() - .write_all(&email) + .write_all(email) .await .map_err(error::client)?; let output = process.output().await.map_err(error::client)?; @@ -292,7 +292,7 @@ impl AsyncTransport for AsyncSendmailTransport { .stdin .as_mut() .unwrap() - .write_all(&email) + .write_all(email) .await .map_err(error::client)?; let output = process.wait_with_output().await.map_err(error::client)?; diff --git a/src/transport/smtp/async_transport.rs b/src/transport/smtp/async_transport.rs index eeea48d..b7f0334 100644 --- a/src/transport/smtp/async_transport.rs +++ b/src/transport/smtp/async_transport.rs @@ -301,7 +301,7 @@ where .await?; if let Some(credentials) = &self.info.credentials { - conn.auth(&self.info.authentication, &credentials).await?; + conn.auth(&self.info.authentication, credentials).await?; } Ok(conn) } diff --git a/src/transport/smtp/client/net.rs b/src/transport/smtp/client/net.rs index 6f5a979..597d445 100644 --- a/src/transport/smtp/client/net.rs +++ b/src/transport/smtp/client/net.rs @@ -161,7 +161,7 @@ impl NetworkStream { let domain = DNSNameRef::try_from_ascii_str(tls_parameters.domain()) .map_err(error::connection)?; - let stream = StreamOwned::new(ClientSession::new(&connector, domain), tcp_stream); + let stream = StreamOwned::new(ClientSession::new(connector, domain), tcp_stream); InnerNetworkStream::RustlsTls(stream) } diff --git a/src/transport/smtp/transport.rs b/src/transport/smtp/transport.rs index 348db51..9b9d2ae 100644 --- a/src/transport/smtp/transport.rs +++ b/src/transport/smtp/transport.rs @@ -225,7 +225,7 @@ impl SmtpClient { } if let Some(credentials) = &self.info.credentials { - conn.auth(&self.info.authentication, &credentials)?; + conn.auth(&self.info.authentication, credentials)?; } Ok(conn) }