rust/lettre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clippy: deny string_add (#735)

Browse Source
This commit is contained in:
Paolo Barbolini
2022-02-12 18:12:41 +01:00
committed by GitHub
parent 9a8aa46dba
commit 7a0dd5bd92
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib.rs
View File

@@ -110,7 +110,9 @@
trivial_numeric_casts, trivial_numeric_casts,
unstable_features, unstable_features,
unused_import_braces, unused_import_braces,
rust_2018_idioms rust_2018_idioms,
clippy::string_add,
clippy::string_add_assign
)] )]
#![cfg_attr(docsrs, feature(doc_cfg))] #![cfg_attr(docsrs, feature(doc_cfg))]

7
src/message/dkim.rs
View File

@@ -349,9 +349,10 @@ pub(super) fn dkim_sign(message: &mut Message, dkim_config: &DkimConfig) {
&dkim_header, &dkim_header,
dkim_config.canonicalization.header, dkim_config.canonicalization.header,
); );
let to_be_signed = signed_headers + &canonicalized_dkim_header; let mut hashed_headers = Sha256::new();
let to_be_signed = to_be_signed.trim_end(); hashed_headers.update(signed_headers.as_bytes());
let hashed_headers = Sha256::digest(to_be_signed.as_bytes()); hashed_headers.update(canonicalized_dkim_header.trim_end().as_bytes());
let hashed_headers = hashed_headers.finalize();
let signature = match &dkim_config.private_key.0 { let signature = match &dkim_config.private_key.0 {
InnerDkimSigningKey::Rsa(private_key) => base64::encode( InnerDkimSigningKey::Rsa(private_key) => base64::encode(
private_key private_key