From 0141c957887aa9fe0340459d644d92cb9e6b0627 Mon Sep 17 00:00:00 2001 From: Fernando Luz Date: Tue, 7 Nov 2023 12:13:05 +0000 Subject: [PATCH] build: Add warning when missing postgres submodule during the build (#5614) I forked the project and in my local repo, I wasn't able to compile the project and in my search, I found the solution in neon forum. After a PR discussion, I made a change in the makefile to alert the missing `git submodules update` step. --------- Signed-off-by: Fernando Luz Co-authored-by: Joonas Koivunen --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 64bbc1677c..89acbe564a 100644 --- a/Makefile +++ b/Makefile @@ -72,6 +72,10 @@ neon: postgres-headers walproposer-lib # $(POSTGRES_INSTALL_DIR)/build/%/config.status: +@echo "Configuring Postgres $* build" + @test -s $(ROOT_PROJECT_DIR)/vendor/postgres-$*/configure || { \ + echo "\nPostgres submodule not found in $(ROOT_PROJECT_DIR)/vendor/postgres-$*/, execute "; \ + echo "'git submodule update --init --recursive --depth 2 --progress .' in project root.\n"; \ + exit 1; } mkdir -p $(POSTGRES_INSTALL_DIR)/build/$* (cd $(POSTGRES_INSTALL_DIR)/build/$* && \ env PATH="$(EXTRA_PATH_OVERRIDES):$$PATH" $(ROOT_PROJECT_DIR)/vendor/postgres-$*/configure \