From 01ccb34118d3d2b0481ea02d9db38fdb4a659f86 Mon Sep 17 00:00:00 2001
From: Alexander Lakhin <alexander.lakhin@neon.tech>
Date: Tue, 17 Jun 2025 11:08:43 +0300
Subject: [PATCH] Don't rerun failed tests in 'Build and Test with Sanitizers'
 workflow (#12259)

## Problem

We could easily miss a sanitizer-detected defect, if it occurred due to
some race condition, as we just rerun the test and if it succeeds, the
overall test run is considered successful. It was more reasonable
before, when we had much more unstable tests in main, but now we can
track all test failures.

## Summary of changes
Don't rerun failed tests.
---
 .github/workflows/_build-and-test-locally.yml        | 4 ++--
 .github/workflows/build_and_run_selected_test.yml    | 2 +-
 .github/workflows/build_and_test_fully.yml           | 2 +-
 .github/workflows/build_and_test_with_sanitizers.yml | 1 +
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/_build-and-test-locally.yml b/.github/workflows/_build-and-test-locally.yml
index 4729aea4f6..3f66f41ef2 100644
--- a/.github/workflows/_build-and-test-locally.yml
+++ b/.github/workflows/_build-and-test-locally.yml
@@ -38,7 +38,7 @@ on:
         required: false
         default: 1
         type: number
-      rerun_failed:
+      rerun-failed:
         description: 'rerun failed tests to ignore flaky tests'
         required: false
         default: true
@@ -392,7 +392,7 @@ jobs:
           run_with_real_s3: true
           real_s3_bucket: neon-github-ci-tests
           real_s3_region: eu-central-1
-          rerun_failed: ${{ inputs.rerun_failed }}
+          rerun_failed: ${{ inputs.rerun-failed }}
           pg_version: ${{ matrix.pg_version }}
           sanitizers: ${{ inputs.sanitizers }}
           aws-oidc-role-arn: ${{ vars.DEV_AWS_OIDC_ROLE_ARN }}
diff --git a/.github/workflows/build_and_run_selected_test.yml b/.github/workflows/build_and_run_selected_test.yml
index 0f53d44a13..6d3541d1b6 100644
--- a/.github/workflows/build_and_run_selected_test.yml
+++ b/.github/workflows/build_and_run_selected_test.yml
@@ -58,7 +58,7 @@ jobs:
       test-cfg: ${{ inputs.pg-versions }}
       test-selection: ${{ inputs.test-selection }}
       test-run-count: ${{ fromJson(inputs.run-count) }}
-      rerun_failed: false
+      rerun-failed: false
     secrets: inherit
 
   create-test-report:
diff --git a/.github/workflows/build_and_test_fully.yml b/.github/workflows/build_and_test_fully.yml
index 7d6543ee26..dd1d63b02b 100644
--- a/.github/workflows/build_and_test_fully.yml
+++ b/.github/workflows/build_and_test_fully.yml
@@ -79,7 +79,7 @@ jobs:
       build-tools-image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
       build-tag: ${{ needs.tag.outputs.build-tag }}
       build-type: ${{ matrix.build-type }}
-      rerun_failed: false
+      rerun-failed: false
       test-cfg: '[{"pg_version":"v14", "lfc_state": "with-lfc"},
                   {"pg_version":"v15", "lfc_state": "with-lfc"},
                   {"pg_version":"v16", "lfc_state": "with-lfc"},
diff --git a/.github/workflows/build_and_test_with_sanitizers.yml b/.github/workflows/build_and_test_with_sanitizers.yml
index c54448dedc..32fb3c7c15 100644
--- a/.github/workflows/build_and_test_with_sanitizers.yml
+++ b/.github/workflows/build_and_test_with_sanitizers.yml
@@ -79,6 +79,7 @@ jobs:
       build-tools-image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
       build-tag: ${{ needs.tag.outputs.build-tag }}
       build-type: ${{ matrix.build-type }}
+      rerun-failed: false
       test-cfg: '[{"pg_version":"v17"}]'
       sanitizers: enabled
     secrets: inherit