From 0205a442659ceddac1e5f3b564222a2985043513 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Mon, 28 Nov 2022 09:44:51 +0200 Subject: [PATCH] Remove obsolete TODO and settings in test The GC and compaction loops have reacted quickly to shutdown request since commit 40c845e57d. --- test_runner/regress/test_tenant_tasks.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/test_runner/regress/test_tenant_tasks.py b/test_runner/regress/test_tenant_tasks.py index a6e935035c..aedc4b2bb7 100644 --- a/test_runner/regress/test_tenant_tasks.py +++ b/test_runner/regress/test_tenant_tasks.py @@ -11,13 +11,6 @@ def get_only_element(l): # noqa: E741 # Test that gc and compaction tenant tasks start and stop correctly def test_tenant_tasks(neon_env_builder: NeonEnvBuilder): - # The gc and compaction loops don't bother to watch for tenant state - # changes while sleeping, so we use small periods to make this test - # run faster. With default settings we'd have to wait longer for tasks - # to notice state changes and shut down. - # TODO fix this behavior in the pageserver - tenant_config = "{gc_period = '1 s', compaction_period = '1 s'}" - neon_env_builder.pageserver_config_override = f"tenant_config={tenant_config}" name = "test_tenant_tasks" env = neon_env_builder.init_start() client = env.pageserver.http_client()