rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-06 13:02:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

monitor: improve logging (#5099)

Browse Source
This commit is contained in:
Felix Prasanna
2023-08-25 10:09:53 -04:00
committed by GitHub
parent f71c82e5de
commit 024e306f73
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/vm_monitor/src/lib.rs
View File

@@ -200,6 +200,6 @@ async fn start_monitor(
match monitor.run().await {
Ok(()) => info!("monitor was killed due to new connection"),
Err(e) => error!(error = ?e, "monitor terminated by itself"),
Err(e) => error!(error = ?e, "monitor terminated unexpectedly"),
}
}

10
libs/vm_monitor/src/runner.rs
View File

@@ -408,7 +408,9 @@ impl Runner {
// there is a message from the informant
msg = self.dispatcher.source.next() => {
if let Some(msg) = msg {
info!(message = ?msg, "received message");
// Don't use 'message' as a key as the string also uses
// that for its key
info!(?msg, "received message");
match msg {
Ok(msg) => {
let message: InboundMsg = match msg {
@@ -417,7 +419,9 @@ impl Runner {
}
other => {
warn!(
message = ?other,
// Don't use 'message' as a key as the
// string also uses that for its key
msg = ?other,
"informant should only send text messages but received different type"
);
continue
@@ -429,7 +433,7 @@ impl Runner {
Ok(None) => continue,
Err(e) => {
let error = e.to_string();
warn!(%error, "error handling message");
warn!(?error, "error handling message");
OutboundMsg::new(
OutboundMsgKind::InternalError {
error