From 0290893bcccfdfba1753a25a20bda0755ce16332 Mon Sep 17 00:00:00 2001 From: Stas Kelvich Date: Fri, 5 Aug 2022 14:56:34 +0300 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a03cfdda48..f1fba50491 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,18 +11,13 @@ than it was before. ## Submitting changes -1. Make a PR for every change. - - Even seemingly trivial patches can break things in surprising ways. -Use of common sense is OK. If you're only fixing a typo in a comment, -it's probably fine to just push it. But if in doubt, open a PR. - -2. Get at least one +1 on your PR before you push. +1. Get at least one +1 on your PR before you push. For simple patches, it will only take a minute for someone to review -it. +it. PR force-push breaks unadressed review comments, so it is better to +just commit follow ups and squash later during the merge. -3. Always keep the CI green. +2. Always keep the CI green. Do not push, if the CI failed on your PR. Even if you think it's not your patch's fault. Help to fix the root cause if something else has