From 0ca2bd929b8753e946fff83cdaa8f2b0062f6ae1 Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Fri, 15 Apr 2022 22:53:31 +0300 Subject: [PATCH] Remove log crate from pageserver --- Cargo.lock | 1 - pageserver/Cargo.toml | 1 - pageserver/src/basebackup.rs | 2 +- pageserver/src/layered_repository/delta_layer.rs | 2 +- pageserver/src/layered_repository/image_layer.rs | 2 +- pageserver/src/layered_repository/inmemory_layer.rs | 2 +- pageserver/src/tenant_mgr.rs | 2 +- pageserver/src/walredo.rs | 2 +- 8 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 0cdeb106ec..e93e73f087 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1526,7 +1526,6 @@ dependencies = [ "hyper", "itertools", "lazy_static", - "log", "nix", "once_cell", "postgres", diff --git a/pageserver/Cargo.toml b/pageserver/Cargo.toml index e92ac0421c..3825795059 100644 --- a/pageserver/Cargo.toml +++ b/pageserver/Cargo.toml @@ -14,7 +14,6 @@ hex = "0.4.3" hyper = "0.14" itertools = "0.10.3" lazy_static = "1.4.0" -log = "0.4.14" clap = "3.0" daemonize = "0.4.1" tokio = { version = "1.17", features = ["process", "sync", "macros", "fs", "rt", "io-util", "time"] } diff --git a/pageserver/src/basebackup.rs b/pageserver/src/basebackup.rs index 3caf27b9b3..077e7c9f83 100644 --- a/pageserver/src/basebackup.rs +++ b/pageserver/src/basebackup.rs @@ -12,13 +12,13 @@ //! use anyhow::{ensure, Context, Result}; use bytes::{BufMut, BytesMut}; -use log::*; use std::fmt::Write as FmtWrite; use std::io; use std::io::Write; use std::sync::Arc; use std::time::SystemTime; use tar::{Builder, EntryType, Header}; +use tracing::*; use crate::reltag::SlruKind; use crate::repository::Timeline; diff --git a/pageserver/src/layered_repository/delta_layer.rs b/pageserver/src/layered_repository/delta_layer.rs index dd6b5d3afa..6e3d65a94d 100644 --- a/pageserver/src/layered_repository/delta_layer.rs +++ b/pageserver/src/layered_repository/delta_layer.rs @@ -38,8 +38,8 @@ use crate::walrecord; use crate::{ZTenantId, ZTimelineId}; use crate::{DELTA_FILE_MAGIC, STORAGE_FORMAT_VERSION}; use anyhow::{bail, ensure, Context, Result}; -use log::*; use serde::{Deserialize, Serialize}; +use tracing::*; // avoid binding to Write (conflicts with std::io::Write) // while being able to use std::fmt::Write's methods use std::fmt::Write as _; diff --git a/pageserver/src/layered_repository/image_layer.rs b/pageserver/src/layered_repository/image_layer.rs index 08e635f073..0f334658bf 100644 --- a/pageserver/src/layered_repository/image_layer.rs +++ b/pageserver/src/layered_repository/image_layer.rs @@ -35,7 +35,6 @@ use crate::{IMAGE_FILE_MAGIC, STORAGE_FORMAT_VERSION}; use anyhow::{bail, ensure, Context, Result}; use bytes::Bytes; use hex; -use log::*; use serde::{Deserialize, Serialize}; use std::fs; use std::io::Write; @@ -43,6 +42,7 @@ use std::io::{Seek, SeekFrom}; use std::ops::Range; use std::path::{Path, PathBuf}; use std::sync::{RwLock, RwLockReadGuard}; +use tracing::*; use zenith_utils::bin_ser::BeSer; use zenith_utils::lsn::Lsn; diff --git a/pageserver/src/layered_repository/inmemory_layer.rs b/pageserver/src/layered_repository/inmemory_layer.rs index a45af51487..ffb5be1dd4 100644 --- a/pageserver/src/layered_repository/inmemory_layer.rs +++ b/pageserver/src/layered_repository/inmemory_layer.rs @@ -16,8 +16,8 @@ use crate::repository::{Key, Value}; use crate::walrecord; use crate::{ZTenantId, ZTimelineId}; use anyhow::{bail, ensure, Result}; -use log::*; use std::collections::HashMap; +use tracing::*; // avoid binding to Write (conflicts with std::io::Write) // while being able to use std::fmt::Write's methods use std::fmt::Write as _; diff --git a/pageserver/src/tenant_mgr.rs b/pageserver/src/tenant_mgr.rs index aeff718803..2765554cf9 100644 --- a/pageserver/src/tenant_mgr.rs +++ b/pageserver/src/tenant_mgr.rs @@ -13,13 +13,13 @@ use crate::walredo::PostgresRedoManager; use crate::{DatadirTimelineImpl, RepositoryImpl}; use anyhow::{Context, Result}; use lazy_static::lazy_static; -use log::*; use serde::{Deserialize, Serialize}; use serde_with::{serde_as, DisplayFromStr}; use std::collections::hash_map::Entry; use std::collections::HashMap; use std::fmt; use std::sync::{Arc, Mutex, MutexGuard}; +use tracing::*; use zenith_utils::zid::{ZTenantId, ZTimelineId}; lazy_static! { diff --git a/pageserver/src/walredo.rs b/pageserver/src/walredo.rs index ae22f1eead..b7c6ecf726 100644 --- a/pageserver/src/walredo.rs +++ b/pageserver/src/walredo.rs @@ -21,7 +21,6 @@ use byteorder::{ByteOrder, LittleEndian}; use bytes::{BufMut, Bytes, BytesMut}; use lazy_static::lazy_static; -use log::*; use nix::poll::*; use serde::Serialize; use std::fs; @@ -35,6 +34,7 @@ use std::process::{Child, ChildStderr, ChildStdin, ChildStdout, Command}; use std::sync::Mutex; use std::time::Duration; use std::time::Instant; +use tracing::*; use zenith_metrics::{register_histogram, register_int_counter, Histogram, IntCounter}; use zenith_utils::bin_ser::BeSer; use zenith_utils::lsn::Lsn;