From 0cceb14e485bddcdfd608a57a4b68eab792af58a Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Thu, 12 Jan 2023 13:12:40 +0200 Subject: [PATCH] Add a FIXME on ugly error message parsing. --- pageserver/src/import_datadir.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pageserver/src/import_datadir.rs b/pageserver/src/import_datadir.rs index 8c9c7120c0..3fd4bf12ca 100644 --- a/pageserver/src/import_datadir.rs +++ b/pageserver/src/import_datadir.rs @@ -143,6 +143,10 @@ async fn import_rel( // Call put_rel_creation for every segment of the relation, // because there is no guarantee about the order in which we are processing segments. // ignore "relation already exists" error + // + // FIXME: use proper error type for this, instead of parsing the error message. + // Or better yet, keep track of which relations we've already created + // https://github.com/neondatabase/neon/issues/3309 if let Err(e) = modification.put_rel_creation(rel, nblocks as u32).await { if e.to_string().contains("already exists") { debug!("relation {} already exists. we must be extending it", rel);